RESOLVED FIXED 110262
[Chromium] Move WebKitPlatformSupport declaration to Platform.h 
https://bugs.webkit.org/show_bug.cgi?id=110262
Summary [Chromium] Move WebKitPlatformSupport declaration to Platform.h
Mark Pilgrim (Google)
Reported 2013-02-19 14:20:50 PST
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
Attachments
Patch (2.86 KB, patch)
2013-02-19 14:22 PST, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2013-02-19 14:22:25 PST
Created attachment 189160 [details] Patch
WebKit Review Bot
Comment 2 2013-02-19 14:25:55 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Dimitri Glazkov (Google)
Comment 3 2013-02-19 14:28:44 PST
Comment on attachment 189160 [details] Patch whoa.
Adam Barth
Comment 4 2013-02-19 14:30:24 PST
Comment on attachment 189160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=189160&action=review > Source/Platform/chromium/public/Platform.h:491 > +class WebKitPlatformSupport : public Platform { > +protected: > + ~WebKitPlatformSupport() { } > +}; We should change all consumers to use the name WebKit::Platform instead. :)
Mark Pilgrim (Google)
Comment 5 2013-02-19 14:40:16 PST
(In reply to comment #4) > We should change all consumers to use the name WebKit::Platform instead. :) It's on my list. I want this change first, then update all the #includes downstream ( https://codereview.chromium.org/11824036/ ), then we can remove the entire WK/chromium/public/platform directory.
WebKit Review Bot
Comment 6 2013-02-19 16:16:07 PST
Comment on attachment 189160 [details] Patch Clearing flags on attachment: 189160 Committed r143401: <http://trac.webkit.org/changeset/143401>
WebKit Review Bot
Comment 7 2013-02-19 16:16:11 PST
All reviewed patches have been landed. Closing bug.
Adrienne Walker
Comment 8 2013-02-19 16:24:49 PST
This was reverted along with r143382 for reason: Breaks Chromium win/mac canary compilation Committed r143403: <http://trac.webkit.org/changeset/143403>
Mark Pilgrim (Google)
Comment 9 2013-02-20 12:00:14 PST
Build breakage was fixed, rolled DEPS, let's give this another shot.
WebKit Review Bot
Comment 10 2013-02-20 13:32:58 PST
Comment on attachment 189160 [details] Patch Clearing flags on attachment: 189160 Committed r143496: <http://trac.webkit.org/changeset/143496>
WebKit Review Bot
Comment 11 2013-02-20 13:33:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.