Bug 103492 - Disassembly methods should be able to disassemble to any PrintStream& rather than always using WTF::dataFile()
Summary: Disassembly methods should be able to disassemble to any PrintStream& rather ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 103009
Blocks: 102999
  Show dependency tree / graph
 
Reported: 2012-11-28 00:59 PST by Filip Pizlo
Modified: 2012-11-30 17:24 PST (History)
7 users (show)

See Also:

Attachments
work in progress (30.79 KB, patch)
2012-11-28 01:06 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (30.84 KB, patch)
2012-11-28 15:30 PST, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-11-28 00:59:25 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2012-11-28 01:06:11 PST 
Created attachment 176421 [details]
work in progress

This needs to wait for https://bugs.webkit.org/show_bug.cgi?id=103009
Comment 2 Filip Pizlo 2012-11-28 15:30:10 PST 
Created attachment 176589 [details]
the patch
Comment 3 Mark Hahnenberg 2012-11-28 15:34:52 PST 
Comment on attachment 176589 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=176589&action=review

r=me with the one comment change.

> Source/JavaScriptCore/dfg/DFGGraph.cpp:219
> +                out.print(", "); // If this is the third child is the first non-empty one then make sure we have two blanks preceding it.

"If the third child is the first non-empty one then make sure we have two blanks preceding it." ?
Comment 4 Filip Pizlo 2012-11-30 17:24:46 PST 
Landed in http://trac.webkit.org/changeset/136069