RESOLVED DUPLICATE of bug 115418 103362
Remove 'in' from IDL method signatures
https://bugs.webkit.org/show_bug.cgi?id=103362
Summary Remove 'in' from IDL method signatures
Kentaro Hara
Reported 2012-11-26 22:02:03 PST
e.g. void func(in DOMString str); The Web IDL spec no longer supports 'in'. We'd like to remove 'in' from WebKit IDL files. timothy, thorton, Sam: This change will break Safari's internal build. Safari's internal IDL files have to be updated too (Please just remove 'in' from DOM method signatures). Please ping me once you're ready:)
Attachments
Patch (484.59 KB, patch)
2012-11-26 22:03 PST, Kentaro Hara
no flags
Patch (511.15 KB, patch)
2012-11-26 22:56 PST, Kentaro Hara
abarth: review+
Kentaro Hara
Comment 1 2012-11-26 22:03:58 PST
Early Warning System Bot
Comment 2 2012-11-26 22:24:30 PST
Kent Tamura
Comment 3 2012-11-26 22:34:49 PST
(In reply to comment #0) > timothy, thorton, Sam: This change will break Safari's internal build. Safari's internal IDL files have to be updated too (Please just remove 'in' from DOM method signatures). Please ping me once you're ready:) Why don't you make "in" support just *optional*? If it is optional, you can remove "in" in WebKit sources now.
Kentaro Hara
Comment 4 2012-11-26 22:38:21 PST
(In reply to comment #3) > (In reply to comment #0) > > timothy, thorton, Sam: This change will break Safari's internal build. Safari's internal IDL files have to be updated too (Please just remove 'in' from DOM method signatures). Please ping me once you're ready:) > > Why don't you make "in" support just *optional*? If it is optional, you can remove "in" in WebKit sources now. That's possible. Want to hear thoughts from Apple folks. We're trying to remove old syntaxes from WebKit IDL files and Safari's internal builds in sync (c.f. bug 102670). At present, the IDL parser is full of old and optionally supported legacy syntaxes. We want to remove them at some point (c.f. bug 98980).
Timothy Hatcher
Comment 5 2012-11-26 22:43:58 PST
Removing "in" on our end will not be that simple unless there is a script you have to do it?
Kentaro Hara
Comment 6 2012-11-26 22:50:26 PST
(In reply to comment #5) > Removing "in" on our end will not be that simple unless there is a script you have to do it? Thanks! I used the following scripts. Does it work? $ cd Source/WebCore/ $ find . -regex '.+.idl' | xargs sed -r -i 's/(\()\s*in\s+/\1/g' $ find . -regex '.+.idl' | xargs sed -r -i 's/^(\s+)in\s+/\1/g' $ find . -regex '.+.idl' | xargs sed -r -i 's/(,\s+)in\s+/\1/g'
Kentaro Hara
Comment 7 2012-11-26 22:56:05 PST
Kentaro Hara
Comment 8 2012-11-27 15:58:41 PST
Now bots are green. Would you review the patch so that I can land it once Safari's side gets ready?
Adam Barth
Comment 9 2012-11-27 16:05:35 PST
Comment on attachment 176184 [details] Patch The change itself looks good. We should, of course, be polite and not break the internal Safari build.
Antonio Gomes
Comment 10 2013-10-02 12:38:25 PDT
*** This bug has been marked as a duplicate of bug 115418 ***
Note You need to log in before you can comment on or make changes to this bug.