The Web IDL spec no longer supports 'module'. We already removed 'module's from WebKit IDL files. So we'd like to remove 'module' from the IDL parser. That being said, it looks like Apple's internal builds are still using 'module's. Once they're removed, I'm happy to make a change to the IDL parser.
Created attachment 174941 [details] Patch
Safari uses this script for some internal IDLs that have module in them. I'm fine with this change, but can we wait to land it until next week? That way we have some time to fix our IDLs first. Thanks!
Please coordinate with Timothy to avoid breaking the Safari build.
(In reply to comment #2) > Safari uses this script for some internal IDLs that have module in them. I'm fine with this change, but can we wait to land it until next week? That way we have some time to fix our IDLs first. Thanks! Sure, thanks for the help! You just need to remove module xxx { ...; }; from your IDL files.
timothy: Thanks for commenting here and there! We've already almost removed deprecated IDL syntaxes from WebKit IDL files. However, the IDL parser and code generators still support old syntaxes. We want to eventually remove them. I would appreciate your collaboration.
I'll comment in here once I remove module from our files. Let use know if there is any other syntax that i being removed. Thanks!
Thanks. Bug 98980 is a meta bug. Let's discuss the overall working plan there.
This is safe to land now. I've updated all of our internal IDL files.
Created attachment 175547 [details] patch for landing
(In reply to comment #8) > This is safe to land now. I've updated all of our internal IDL files. I'd appreciate your support!
Comment on attachment 175547 [details] patch for landing Rejecting attachment 175547 [details] from commit-queue. New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Full output: http://queues.webkit.org/results/14961199
Comment on attachment 175547 [details] patch for landing Rejecting attachment 175547 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Merge conflict in Tools/ChangeLog Failed to merge in the changes. Patch failed at 0001 Coordinated Graphics: Remove an invisible TiledBackingStore of CoordinatedGraphicsLayer. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14963287
Comment on attachment 175547 [details] patch for landing Rejecting attachment 175547 [details] from commit-queue. New failing tests: platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html Full output: http://queues.webkit.org/results/14960412
Comment on attachment 175547 [details] patch for landing Clearing flags on attachment: 175547 Committed r135547: <http://trac.webkit.org/changeset/135547>
All reviewed patches have been landed. Closing bug.