RESOLVED FIXED115418
Stop using "in" keyword in IDL files 
https://bugs.webkit.org/show_bug.cgi?id=115418
Summary Stop using "in" keyword in IDL files
Chris Dumez
Reported 2013-04-30 06:25:20 PDT
The "in" keyword for operation arguments has been dropped from the Web IDL spec a long time ago. It brings no additional information and.
Attachments
Patch (518.00 KB, patch)
2013-04-30 06:30 PDT, Chris Dumez 		haraken: review+
DetailsFormatted DiffDiff
Patch for landing (516.84 KB, patch)
2013-04-30 06:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch for landing (516.80 KB, patch)
2013-04-30 06:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2013-04-30 06:27:01 PDT
Please talk with timo@ and timothy@ before landing the change, as it will affect IDL files for Safari internal builds.
Chris Dumez
Comment 2 2013-04-30 06:30:33 PDT
Created attachment 200106 [details] Patch
Kentaro Hara
Comment 3 2013-04-30 06:39:00 PDT
Comment on attachment 200106 [details] Patch I'd encourage you to land the patch excluding the change in IDLParser.pm. As long as you remove 'in' from WebKit IDL files, it won't break anything. However, removing the 'in' support from IDLParser.pm will break Safari's internal build. You can make the change in a follow-up patch, discussing with timo@ and timothy@.
Chris Dumez
Comment 4 2013-04-30 06:52:51 PDT
Created attachment 200111 [details] Patch for landing Reverted change to the IDL parser for now, as suggested by Kentaro.
Chris Dumez
Comment 5 2013-04-30 06:54:46 PDT
Created attachment 200112 [details] Patch for landing Tiny changelog fix.
WebKit Commit Bot
Comment 6 2013-04-30 07:36:30 PDT
Comment on attachment 200112 [details] Patch for landing Clearing flags on attachment: 200112 Committed r149368: <http://trac.webkit.org/changeset/149368>
WebKit Commit Bot
Comment 7 2013-04-30 07:36:32 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 8 2013-10-02 12:38:25 PDT
*** Bug 103362 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 9 2013-10-03 11:31:14 PDT
> discussing with timo@ Where does this e-mail come from? That suggestion is incorrect and should be fixed.
Chris Dumez
Comment 10 2013-10-03 11:35:49 PDT
(In reply to comment #9) > > discussing with timo@ > > Where does this e-mail come from? That suggestion is incorrect and should be fixed. Alexey, I am not sure what you mean. Do you mean that it is OK to make the parser enforce that the "in" keyword is not used in the IDLs? If you say it will not break Safari builds, I am happy to do this in a follow-up patch.
Alexey Proskuryakov
Comment 11 2013-10-03 12:19:12 PDT
Sorry that I was unclear. I'm saying that timo@apple.com has not been working on WebKit since 2006. Presumably there is some wiki page somewhere suggesting to ask him, and this page should be fixed.
Note You need to log in before you can comment on or make changes to this bug.