Bug 115418 - Stop using "in" keyword in IDL files
Summary: Stop using "in" keyword in IDL files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
: 103362 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-30 06:25 PDT by Chris Dumez
Modified: 2013-10-03 12:19 PDT (History)
8 users (show)

See Also:


Attachments
Patch (518.00 KB, patch)
2013-04-30 06:30 PDT, Chris Dumez
haraken: review+
Details | Formatted Diff | Diff
Patch for landing (516.84 KB, patch)
2013-04-30 06:52 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch for landing (516.80 KB, patch)
2013-04-30 06:54 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-04-30 06:25:20 PDT
The "in" keyword for operation arguments has been dropped from the Web IDL spec a long time ago. It brings no additional information and.
Comment 1 Kentaro Hara 2013-04-30 06:27:01 PDT
Please talk with timo@ and timothy@ before landing the change, as it will affect IDL files for Safari internal builds.
Comment 2 Chris Dumez 2013-04-30 06:30:33 PDT
Created attachment 200106 [details]
Patch
Comment 3 Kentaro Hara 2013-04-30 06:39:00 PDT
Comment on attachment 200106 [details]
Patch

I'd encourage you to land the patch excluding the change in IDLParser.pm. As long as you remove 'in' from WebKit IDL files, it won't break anything. However, removing the 'in' support from IDLParser.pm will break Safari's internal build. You can make the change in a follow-up patch, discussing with timo@ and timothy@.
Comment 4 Chris Dumez 2013-04-30 06:52:51 PDT
Created attachment 200111 [details]
Patch for landing

Reverted change to the IDL parser for now, as suggested by Kentaro.
Comment 5 Chris Dumez 2013-04-30 06:54:46 PDT
Created attachment 200112 [details]
Patch for landing

Tiny changelog fix.
Comment 6 WebKit Commit Bot 2013-04-30 07:36:30 PDT
Comment on attachment 200112 [details]
Patch for landing

Clearing flags on attachment: 200112

Committed r149368: <http://trac.webkit.org/changeset/149368>
Comment 7 WebKit Commit Bot 2013-04-30 07:36:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Antonio Gomes 2013-10-02 12:38:25 PDT
*** Bug 103362 has been marked as a duplicate of this bug. ***
Comment 9 Alexey Proskuryakov 2013-10-03 11:31:14 PDT
> discussing with timo@

Where does this e-mail come from? That suggestion is incorrect and should be fixed.
Comment 10 Chris Dumez 2013-10-03 11:35:49 PDT
(In reply to comment #9)
> > discussing with timo@
> 
> Where does this e-mail come from? That suggestion is incorrect and should be fixed.

Alexey, I am not sure what you mean. Do you mean that it is OK to make the parser enforce that the "in" keyword is not used in the IDLs?

If you say it will not break Safari builds, I am happy to do this in a follow-up patch.
Comment 11 Alexey Proskuryakov 2013-10-03 12:19:12 PDT
Sorry that I was unclear. I'm saying that timo@apple.com has not been working on WebKit since 2006. Presumably there is some wiki page somewhere suggesting to ask him, and this page should be fixed.