Bug 103000 – Any function that can log things should be able to easily log them to a memory buffer as well

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

So anytime that we can do:

thing->dump();

We should be able to *also* optionally do something like:

StringStream stream;
thing->dump(stream);
String string = stream.string();

[Filip Pizlo]

Created attachment 175573 [details]
work in progress

[Filip Pizlo]

Created attachment 175577 [details]
the patch

[WebKit Review Bot]

Attachment 175577 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/DataLog.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/PrintStream.h:85:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WTF/wtf/PrintStream.cpp:101:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 175577 [details]
the patch

Attachment 175577 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14969200

[Early Warning System Bot]

Comment on attachment 175577 [details]
the patch

Attachment 175577 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/14962232

[Filip Pizlo]

Created attachment 175581 [details]
the patch

Rabased and fixed some #include bugs.

[WebKit Review Bot]

Attachment 175581 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/WTF/wtf/DataLog.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WTF/wtf/PrintStream.h:85:  Omit int when using unsigned  [runtime/unsigned] [1]
Source/WTF/wtf/PrintStream.cpp:101:  Omit int when using unsigned  [runtime/unsigned] [1]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 175582 [details]
the patch

Fix style.

[Build Bot]

Comment on attachment 175582 [details]
the patch

Attachment 175582 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14966224

[EFL EWS Bot]

Comment on attachment 175582 [details]
the patch

Attachment 175582 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14969237

[Filip Pizlo]

Created attachment 175603 [details]
the patch

More build fixes.

[WebKit Review Bot]

Comment on attachment 175603 [details]
the patch

Attachment 175603 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14967379

New failing tests:
platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html

[Filip Pizlo]

Created attachment 175728 [details]
the patch

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/135640