Tracking Bug We are using TYPE_MISMATCH_ERR in cases where we shouldn't and it is likely that this will be deprecated too: https://www.w3.org/Bugs/Public/show_bug.cgi?id=19898
Created attachment 173341 [details] Patch
Comment on attachment 173341 [details] Patch ok
Created attachment 173653 [details] Patch for landing
Comment on attachment 173653 [details] Patch for landing Rejecting attachment 173653 [details] from commit-queue. New failing tests: media/encrypted-media/encrypted-media-syntax.html fast/mediastream/RTCPeerConnection.html Full output: http://queues.webkit.org/results/14821221
Created attachment 173737 [details] Patch for landing
Comment on attachment 173737 [details] Patch for landing Clearing flags on attachment: 173737 Committed r134345: <http://trac.webkit.org/changeset/134345>
All reviewed patches have been landed. Closing bug.
Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426. CC'ing Roger since I don't have a Mac to fix the pixel expectations for it.
Comment on attachment 173737 [details] Patch for landing This caused me to look at bug 91679, where NATIVE_TYPE_ERR was added. Unfortunately, that patch did not correctly add this new error code for bindings other than JavaScript, so using this new error code in lots of new places makes a potential problem with NATIVE_TYPE_ERR now a practical problem, for the Objective-C bindings for example. This needs to be fixed. Please see my comments in bug 91679 for details. I suggest rolling this change back until those issues are dealt with, or dealing with them quickly.
Re-opened since this is blocked by bug 102106
(In reply to comment #8) > Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426. > > CC'ing Roger since I don't have a Mac to fix the pixel expectations for it. ... Qt, GTK+, Mac and EFL expectations fixed in <http://trac.webkit.org/changeset/134444> after the rollout.
(In reply to comment #11) > (In reply to comment #8) > > Qt updated its text expectation for fast/dynamic/insertAdjacentElement.html in r134388 and I've updated the expectations for GTK+, Mac and EFL in r134426. > > > > CC'ing Roger since I don't have a Mac to fix the pixel expectations for it. > > ... Qt, GTK+, Mac and EFL expectations fixed in <http://trac.webkit.org/changeset/134444> after the rollout. I should have rolled those other patches out at the same time. :( Sorry, and thanks for cleaning up.