Bug 101502 – Wrong error type is thrown for type errors in callbacks

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Erik Arvidsson]

"4.2.21. Callback function types

IDL callback function types are represented by ECMAScript Function objects.

An ECMAScript value V is converted to an IDL callback function type value by running the following algorithm:

If V is not a Function object, then throw a TypeError.
Return the IDL callback function type value that represents a reference to that Function object.
The result of converting an IDL callback function type value to an ECMAScript value is a reference to the same object that the IDL callback function type value represents."

We throw a TYPE_MISMATCH_ERR DOMException instead.

[Joshua Bell]

Looks like this would be easy to fix in the code generators.

Watch out for overloads in addition to the normal case; we may do different checking for overloads.

[Erik Arvidsson]

Created attachment 173045 [details]
Patch

[Joshua Bell]

It doesn't look like run-bindings-tests --reset-results was run, so this will probably fail the bots.

LGTM otherwise; sad that our coverage is so poor, but at least it means this change is likely Web-compatible.

[Erik Arvidsson]

Created attachment 173061 [details]
Patch

[Erik Arvidsson]

(In reply to comment #3)
> It doesn't look like run-bindings-tests --reset-results was run, so this will probably fail the bots.

Oops. Done.

[Adam Barth]

Comment on attachment 173061 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 173061 [details]
Patch

Clearing flags on attachment: 173061

Committed r133932: <http://trac.webkit.org/changeset/133932>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.