Bug 101631 - setAttributeNode and friends should not have optional argument
Summary: setAttributeNode and friends should not have optional argument
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on: 102118
Blocks: 101604
  Show dependency treegraph
 
Reported: 2012-11-08 11:55 PST by Erik Arvidsson
Modified: 2017-07-18 08:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.84 KB, patch)
2012-11-08 11:59 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2012-11-08 12:40 PST, Erik Arvidsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2012-11-08 11:55:21 PST
setAttributeNode and friends should not have optional argument
Comment 1 Erik Arvidsson 2012-11-08 11:59:52 PST
Created attachment 173087 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-11-08 12:29:13 PST
Comment on attachment 173087 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review

> Source/WebCore/ChangeLog:9
> +        Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove
> +        some special case code that only exist in CodeGeneratorV8.pm.

Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript.
Comment 3 Erik Arvidsson 2012-11-08 12:32:36 PST
(In reply to comment #2)
> (From update of attachment 173087 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=173087&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Make the Attr argument to setAttributeNode etc mandatory. This allows us to remove
> > +        some special case code that only exist in CodeGeneratorV8.pm.
> 
> Removing some code from WebKit is not a meaningful rationale for a change that is observable from JavaScript.

Let me update the ChangeLog.

With this change we match the spec and we better match other browsers.
Comment 4 Erik Arvidsson 2012-11-08 12:40:14 PST
Created attachment 173097 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-08 13:52:44 PST
Comment on attachment 173097 [details]
Patch

Clearing flags on attachment: 173097

Committed r133944: <http://trac.webkit.org/changeset/133944>
Comment 6 WebKit Review Bot 2012-11-08 13:52:47 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2012-11-13 12:06:59 PST
Re-opened since this is blocked by bug 102118