WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100051
IndexedDB: Cursor property value identities should be preserved
https://bugs.webkit.org/show_bug.cgi?id=100051
Summary
IndexedDB: Cursor property value identities should be preserved
Joshua Bell
Reported
2012-10-22 16:38:48 PDT
IndexedDB: Cursor property value identities should be preserved
Attachments
Patch
(14.97 KB, patch)
2012-10-22 16:44 PDT
,
Joshua Bell
no flags
Details
Formatted Diff
Diff
Patch
(14.92 KB, patch)
2012-10-23 11:30 PDT
,
Joshua Bell
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Joshua Bell
Comment 1
2012-10-22 16:44:09 PDT
Created
attachment 170021
[details]
Patch
Joshua Bell
Comment 2
2012-10-22 16:45:35 PDT
Comment on
attachment 170021
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=170021&action=review
This patch will almost certainly conflict with
https://bugs.webkit.org/show_bug.cgi?id=100034
and need to be rebased before landing.
> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:272 > + v8::Context::Scope contextScope(toV8Context(scriptContext, UseCurrentWorld));
This should change depending on what happens with
https://bugs.webkit.org/show_bug.cgi?id=99975
Joshua Bell
Comment 3
2012-10-22 16:45:51 PDT
alecflett@ - please take a look
Joshua Bell
Comment 4
2012-10-22 16:49:03 PDT
With this patch we pass:
http://w3c-test.org/webapps/IndexedDB/tests/submissions/Opera/idbcursor-key.htm
http://w3c-test.org/webapps/IndexedDB/tests/submissions/Opera/idbcursor-primarykey.htm
Joshua Bell
Comment 5
2012-10-23 11:30:54 PDT
Created
attachment 170198
[details]
Patch
Joshua Bell
Comment 6
2012-10-23 11:34:22 PDT
(In reply to
comment #5
)
> Created an attachment (id=170198) [details] > Patch
Just rebased after 100034
Alec Flett
Comment 7
2012-10-24 11:58:26 PDT
lgtm
WebKit Review Bot
Comment 8
2012-10-24 14:37:10 PDT
Comment on
attachment 170198
[details]
Patch Clearing flags on attachment: 170198 Committed
r132401
: <
http://trac.webkit.org/changeset/132401
>
WebKit Review Bot
Comment 9
2012-10-24 14:37:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug