100051 – IndexedDB: Cursor property value identities should be preserved

Bug 100051 - IndexedDB: Cursor property value identities should be preserved

Summary: IndexedDB: Cursor property value identities should be preserved

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Joshua Bell

URL:
Keywords:

Depends on:	100034
Blocks:	97375
	Show dependency tree / graph

Reported:	2012-10-22 16:38 PDT by Joshua Bell
Modified:	2012-10-24 14:37 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (14.97 KB, patch) 2012-10-22 16:44 PDT, Joshua Bell	no flags	Details \| Formatted Diff \| Diff
Patch (14.92 KB, patch) 2012-10-23 11:30 PDT, Joshua Bell	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Joshua Bell 2012-10-22 16:38:48 PDT

IndexedDB: Cursor property value identities should be preserved

Comment 1 Joshua Bell 2012-10-22 16:44:09 PDT

Created attachment 170021 [details]
Patch

Comment 2 Joshua Bell 2012-10-22 16:45:35 PDT

Comment on attachment 170021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=170021&action=review

This patch will almost certainly conflict with https://bugs.webkit.org/show_bug.cgi?id=100034 and need to be rebased before landing.

> Source/WebCore/bindings/v8/IDBBindingUtilities.cpp:272
> +    v8::Context::Scope contextScope(toV8Context(scriptContext, UseCurrentWorld));

This should change depending on what happens with https://bugs.webkit.org/show_bug.cgi?id=99975

Comment 3 Joshua Bell 2012-10-22 16:45:51 PDT

alecflett@ - please take a look

Comment 4 Joshua Bell 2012-10-22 16:49:03 PDT

With this patch we pass:

http://w3c-test.org/webapps/IndexedDB/tests/submissions/Opera/idbcursor-key.htm
http://w3c-test.org/webapps/IndexedDB/tests/submissions/Opera/idbcursor-primarykey.htm

Comment 5 Joshua Bell 2012-10-23 11:30:54 PDT

Created attachment 170198 [details]
Patch

Comment 6 Joshua Bell 2012-10-23 11:34:22 PDT

(In reply to comment #5)
> Created an attachment (id=170198) [details]
> Patch

Just rebased after 100034

Comment 7 Alec Flett 2012-10-24 11:58:26 PDT

lgtm

Comment 8 WebKit Review Bot 2012-10-24 14:37:10 PDT

Comment on attachment 170198 [details]
Patch

Clearing flags on attachment: 170198

Committed r132401: <http://trac.webkit.org/changeset/132401>

Comment 9 WebKit Review Bot 2012-10-24 14:37:14 PDT

All reviewed patches have been landed.  Closing bug.