RESOLVED FIXED 100034
IndexedDB: Remove custom binding code for IDBCursor.value 
https://bugs.webkit.org/show_bug.cgi?id=100034
Summary IndexedDB: Remove custom binding code for IDBCursor.value
Joshua Bell
Reported 2012-10-22 14:40:22 PDT
IndexedDB: Remove custom binding code for IDBCursor.value
Attachments
Patch (10.96 KB, patch)
2012-10-22 14:43 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-10-22 14:43:12 PDT
Created attachment 169990 [details] Patch
Joshua Bell
Comment 2 2012-10-22 14:43:46 PDT
alecflett@ - can you take a look?
Alec Flett
Comment 3 2012-10-22 14:53:19 PDT
Comment on attachment 169990 [details] Patch lgtm!
Joshua Bell
Comment 4 2012-10-22 14:54:59 PDT
haraken@ - r? cq?
Kentaro Hara
Comment 5 2012-10-22 22:11:19 PDT
Comment on attachment 169990 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=169990&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:-64953 > - RelativePath="..\bindings\js\IDBCustomBindings.cpp" This looks strange. js/IDBCustomBindings.cpp has not existed in the first place, right? (Either way, landing this patch would be safe. I'll cq+ it.)
WebKit Review Bot
Comment 6 2012-10-22 22:21:33 PDT
Comment on attachment 169990 [details] Patch Clearing flags on attachment: 169990 Committed r132179: <http://trac.webkit.org/changeset/132179>
WebKit Review Bot
Comment 7 2012-10-22 22:21:38 PDT
All reviewed patches have been landed. Closing bug.
Joshua Bell
Comment 8 2012-10-23 12:04:29 PDT
(In reply to comment #5) > (From update of attachment 169990 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=169990&action=review > > > Source/WebCore/WebCore.vcproj/WebCore.vcproj:-64953 > > - RelativePath="..\bindings\js\IDBCustomBindings.cpp" > > This looks strange. js/IDBCustomBindings.cpp has not existed in the first place, right? (Either way, landing this patch would be safe. I'll cq+ it.) Wow, I didn't even notice. Looks like the path was added as js rather than v8 by mistake in r120241 Anyway, yeah, good/safe to remove.
Note You need to log in before you can comment on or make changes to this bug.