Bug 98724

Summary: [EFL] Remove "web" word in web inspector
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: js45.yang, lucas.de.marchi, rakuco, seokju.kwon, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Gyuyoung Kim
Reported 2012-10-08 23:16:08 PDT
Remove "web" word from ewk files in order to be consistent with WK2. Bug 97886 and Bug 97887 removed *web* from WK2. This was discussed in webkit-efl mailing list. http://lists.webkit.org/pipermail/webkit-efl/2012-September/000308.html.
Attachments
Patch (57.67 KB, patch)
2012-10-08 23:25 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (57.66 KB, patch)
2012-10-09 00:35 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (19.26 KB, patch)
2012-10-09 04:29 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2012-10-08 23:25:49 PDT
Created attachment 167695 [details] Patch
Gyuyoung Kim
Comment 2 2012-10-09 00:35:09 PDT
Created attachment 167702 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-10-09 03:03:55 PDT
I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database).
Jongseok Yang
Comment 4 2012-10-09 03:16:31 PDT
(In reply to comment #3) > I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database). The WK API name for Web Database is just WKDatabaseXXXXX. So, I think that we can remove "web" word from the implementation for web databases.
Gyuyoung Kim
Comment 5 2012-10-09 03:47:21 PDT
(In reply to comment #3) > I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database). As Raphael said, we may argue with web database and web audio in WK1. Because other ports in WK1 are still using *web*. It looks I need to consider this further. BTW, how about removing web from web_inspector ? I think *web* is redundant in inspector.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-10-09 04:02:02 PDT
(In reply to comment #5) > (In reply to comment #3) > > I disagree with blind replacements like this -- some features simply have 'web' in their names, such as Web Audio or Web Databases (which is actually Web SQL Database). > > As Raphael said, we may argue with web database and web audio in WK1. Because other ports in WK1 are still using *web*. It looks I need to consider this further. > > BTW, how about removing web from web_inspector ? I think *web* is redundant in inspector. Yeah, I think removing this one is OK.
Gyuyoung Kim
Comment 7 2012-10-09 04:29:05 PDT
Created attachment 167732 [details] Patch
Gyuyoung Kim
Comment 8 2012-10-09 04:30:32 PDT
I only remove *web* from web inspector. Other will be considered further. Jongseok and Seokju, how do you think ?
Gyuyoung Kim
Comment 9 2012-10-09 04:31:58 PDT
Beside other ports just use *inspector* except for gtk and win ports.
Raphael Kubo da Costa (:rakuco)
Comment 10 2012-10-09 09:37:24 PDT
Comment on attachment 167732 [details] Patch LGTM
Seokju Kwon
Comment 11 2012-10-11 18:01:17 PDT
(In reply to comment #8) > I only remove *web* from web inspector. Other will be considered further. Jongseok and Seokju, how do you think ? No problem. I have also removed "web" from web inspector on Bug 98639.
Laszlo Gombos
Comment 12 2012-10-11 18:03:10 PDT
Comment on attachment 167732 [details] Patch This change makes the api more consistent. r=me.
WebKit Review Bot
Comment 13 2012-10-11 18:19:27 PDT
Comment on attachment 167732 [details] Patch Clearing flags on attachment: 167732 Committed r131119: <http://trac.webkit.org/changeset/131119>
WebKit Review Bot
Comment 14 2012-10-11 18:19:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.