[GTK] Reevaluate the platform-specific nature of some accessibility tests

• Component: WebKitGTK
• Status: NEW ---

[Zan Dobersek]

The following can currently be found in TestExpectations file:

# Accessibility tests that should never be run for GTK due to be
# written in a platform-specific way. They should either be moved to
# the right platform or re-written in a more platform-agnostic way.
accessibility/aria-list-and-listitem.html [ WontFix ]
accessibility/aria-option-role.html [ WontFix ]
accessibility/internal-link-anchors2.html [ WontFix ]
accessibility/radio-button-group-members.html [ WontFix ]
accessibility/table-attributes.html [ WontFix ]
accessibility/table-detection.html [ WontFix ]
accessibility/table-one-cell.html [ WontFix ]
accessibility/table-sections.html [ WontFix ]
accessibility/table-with-aria-role.html [ WontFix ]
accessibility/table-with-rules.html [ WontFix ]
accessibility/plugin.html [ WontFix ]

I think we should reevaluate this classification, see if any test could be rewritten in platform-independent way and otherwise either remove these tests under proper platform-specific directories or just keep these expectations as they are.

[Mario Sanchez Prada]

(In reply to comment #0)
> The following can currently be found in TestExpectations file:
> 
> # Accessibility tests that should never be run for GTK due to be
> # written in a platform-specific way. They should either be moved to
> # the right platform or re-written in a more platform-agnostic way.
> accessibility/internal-link-anchors2.html [ WontFix ]
> accessibility/radio-button-group-members.html [ WontFix ]
> accessibility/table-attributes.html [ WontFix ]
> accessibility/table-detection.html [ WontFix ]
> accessibility/table-one-cell.html [ WontFix ]
> accessibility/table-sections.html [ WontFix ]
> accessibility/table-with-aria-role.html [ WontFix ]
> accessibility/table-with-rules.html [ WontFix ]
> accessibility/plugin.html [ WontFix ]
> 
> I think we should reevaluate this classification, see if any test could be 
> rewritten in platform-independent way and otherwise either remove these tests 
> under proper platform-specific directories or just keep these expectations as 
> they are.

I agree. Actually, all those tests[*] could be fixed by implementing the corresponding attributesOf*() function in AccessibilityUIElement() for DRT/WKTR, since those functions are currently unimplemented.

More specifically, this is what needs to be implemented:

 * table-attributes.html, table-sections.html:
    - attributesOfColumnHeaders()
    - attributesOfRowHeaders()
    - attributesOfColumns()
    - attributesOfRows()
    - attributesOfHeader()
    - attributesOfVisibleCell()

 * plugin.html, table-with-aria-role.html:
    - attributesOfChildren()

 * internal-link-anchors2.html, radio-button-group-members.html:
    - attributesOfLinkedUIElements

 * table-detection.html, table-one-cell.html, table-with-rules.html:
    - allAtributes()

Additionally, implementing all those functions (specially allAttributes() and attributesOfChildren()) will help us run properly other tests as well, so it looks indeed like something interesting to fix.

I'll be filing bugs for all of them soon, and hopefully working on them too.

[*] With the exception of aria-list-and-listitem.html and accessibility/aria-option-role.html, which are no longer in the TestExpectations file.

[Carlos Alberto Lopez Perez]

accessibility/internal-link-anchors2.html is passing correctly now on wk1/wk2 gtk+. I checked the test and I don't see anything platform specific. I will be removing it from the list.

[Frédéric Wang (:fredw)]

(In reply to comment #2)
> accessibility/internal-link-anchors2.html is passing correctly now on
> wk1/wk2 gtk+. I checked the test and I don't see anything platform specific.
> I will be removing it from the list.

This one is still marked [ WontFix Missing ] so it always generates a text expectation when you run accessibility tests.

@Joanie: can you check whether the result is correct? If so, I think we can just add the missing expectation file and remove this test from TestExpectation.

[Frédéric Wang (:fredw)]

I added accessibility/content-editable-as-textarea.html to that list.

http://trac.webkit.org/changeset/198003

[Frédéric Wang (:fredw)]

http://trac.webkit.org/changeset/198130