Bug 118967 - [ATK] Implement attributesOfChildren() for AccessibilityUIElement
Summary: [ATK] Implement attributesOfChildren() for AccessibilityUIElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: LayoutTestFailure
Depends on: 118966
Blocks: 98348 98382
  Show dependency tree / graph
 
Reported: 2013-07-22 06:26 PDT by Mario Sanchez Prada
Modified: 2013-07-29 11:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch proposal (16.22 KB, patch)
2013-07-26 04:11 PDT, Mario Sanchez Prada 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2013-07-22 06:26:20 PDT 
Implementing this function would help to run properly the following tests, now in TestExpectations:

  accessibility/plugin.html [ WontFix Missing ]
  accessibility/table-with-aria-role.html
  accessibility/visible-elements.html (this also needs attributesOfDocumentLinks(), see bug 98382)

Additionally, it should help to to provide more accurate (and useful!) results for the following tests:

  image-map2.html
  lists.html
  nochildren-elements.html
  removed-continuation-element-causes-crash.html
  table-modification-crash.html
  table-remove-cell-crash.html
Comment 1 Mario Sanchez Prada 2013-07-26 04:11:31 PDT 
Created attachment 207522 [details]
Patch proposal

This patch implements the missing functionality in DRT & WKTR, removes two tests from TestExpectations and updates expectations for 3 more tests.

Please review :)
Comment 2 Mario Sanchez Prada 2013-07-26 04:12:04 PDT 
Adding to CC people that might be interested.
Comment 3 Mario Sanchez Prada 2013-07-26 04:12:59 PDT 
We need to get 118966 first, since it implements a new helper function in AccessibilityUIElement, attributesOfElement().
Comment 4 Mario Sanchez Prada 2013-07-29 11:25:43 PDT 
Committed r153435: <http://trac.webkit.org/changeset/153435>
Comment 5 Mario Sanchez Prada 2013-07-29 11:26:24 PDT 
As with bug 118966, EFL guys might be interested in rebaselining their tests (and maybe unskipping some too), now we are dumping some extra information