Bug 97203

Summary:

Web Inspector: [Canvas] support 2D canvas instrumentation from the inspector C++ code

Product:

WebKit

Reporter:

Andrey Adaikin <aandrey>

Component:

Web Inspector (Deprecated)

Assignee:

Andrey Adaikin <aandrey>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, haraken, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

96746, 97338

Bug Blocks:

97331

Attachments:

Description	Flags
Patch	none
Try again to land	none

Andrey Adaikin

Reported 2012-09-20 05:55:46 PDT

Patch to follow.

Attachments
Patch (11.77 KB, patch) 2012-09-20 06:03 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Try again to land (12.54 KB, patch) 2012-09-24 03:41 PDT, Andrey Adaikin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andrey Adaikin

Comment 1 2012-09-20 06:03:53 PDT

Created attachment 164903 [details] Patch

Yury Semikhatsky

Comment 2 2012-09-21 05:33:57 PDT

Comment on attachment 164903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164903&action=review > Source/WebCore/inspector/InspectorCanvasInstrumentation.h:46 > + if (canvasAgent && canvasAgent->enabled()) You shouldn't check if the agent is enabled here, it should only set itself in instrumentingAgents when it is enabled instead.

Andrey Adaikin

Comment 3 2012-09-21 05:43:57 PDT

(In reply to comment #2) > (From update of attachment 164903 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164903&action=review > > > Source/WebCore/inspector/InspectorCanvasInstrumentation.h:46 > > + if (canvasAgent && canvasAgent->enabled()) > > You shouldn't check if the agent is enabled here, it should only set itself in instrumentingAgents when it is enabled instead. Thanks. Will address this in https://bugs.webkit.org/show_bug.cgi?id=97331

WebKit Review Bot

Comment 4 2012-09-21 05:51:57 PDT

Comment on attachment 164903 [details] Patch Clearing flags on attachment: 164903 Committed r129219: <http://trac.webkit.org/changeset/129219>

WebKit Review Bot

Comment 5 2012-09-21 05:52:02 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 6 2012-09-21 07:18:51 PDT

Re-opened since this is blocked by 97338

Andrey Adaikin

Comment 7 2012-09-24 03:41:07 PDT

Created attachment 165345 [details] Try again to land

WebKit Review Bot

Comment 8 2012-09-24 06:01:12 PDT

Comment on attachment 165345 [details] Try again to land Clearing flags on attachment: 165345 Committed r129353: <http://trac.webkit.org/changeset/129353>

WebKit Review Bot

Comment 9 2012-09-24 06:01:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.