Summary: | IndexedDB: fire upgradeneeded even without an explicit integer version | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Grogan <dgrogan> | ||||||||||||||||||
Component: | New Bugs | Assignee: | David Grogan <dgrogan> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | alecflett, jsbell, tony, webkit.review.bot | ||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Bug Depends on: | 90411 | ||||||||||||||||||||
Bug Blocks: | 96548, 96952 | ||||||||||||||||||||
Attachments: |
|
Description
David Grogan
2012-09-11 16:06:03 PDT
Created attachment 163468 [details]
Patch
Created attachment 163469 [details]
Patch
Created attachment 163488 [details]
Patch
Created attachment 163492 [details]
Patch
With this patch we do indeed pass the w3 tests Josh separated out. Except one, http://w3c-test.org/webapps/IndexedDB/tests/submissions/Ms2ger/idbfactory_open9.htm . It fails because of a different int-version issue. This patch doesn't apply to ToT because it is based on 90411. Created attachment 163725 [details]
Patch
jsbell@, could you take a look at this? As we predicted there's not much code change, mostly tests. Comment on attachment 163725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163725&action=review LGTM! > Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:-342 > - // FIXME: Change this to strictly greater than 0 once we throw TypeError for This patch does not alter the (erroneous) behavior for open(name, -1), correct? It's still an alias for open(name), and that will be fixed (on the front end) in a separate bug? Created attachment 164020 [details]
Patch
Attachment 164020 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1
Source/WebCore/ChangeLog:9: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:11: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 164030 [details]
Patch
Comment on attachment 163725 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163725&action=review >> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:-342 >> - // FIXME: Change this to strictly greater than 0 once we throw TypeError for > > This patch does not alter the (erroneous) behavior for open(name, -1), correct? It's still an alias for open(name), and that will be fixed (on the front end) in a separate bug? That's right. Created attachment 164462 [details]
ToT
Tony, could you review this? I'm not going to land it until tomorrow so it's not urgent at all. Tony, could you review this? I'm not going to land it until tomorrow so it's not urgent at all. Comment on attachment 164462 [details] ToT Clearing flags on attachment: 164462 Committed r129037: <http://trac.webkit.org/changeset/129037> All reviewed patches have been landed. Closing bug. |