Unprefix IndexedDB
Created attachment 163678 [details] Patch
Comment on attachment 163678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163678&action=review > Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.h:45 > static IDBFactory* webkitIndexedDB(DOMWindow*); > + static IDBFactory* indexedDB(DOMWindow*); You should just delete webkitIndexedDB. It's not needed. > Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl:45 > + readonly attribute IDBFactory indexedDB; The webkitIndexedDB entrypoint should use https://trac.webkit.org/wiki/WebKitIDL#ImplementedAs
Comment on attachment 163678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163678&action=review > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please fill out this part of the ChangeLog. For example, do we pass a certain test suite?
Sorry, I shouldn't have marked this r?, but thanks for the early feedback!
Created attachment 163685 [details] unprefixdomwindow
Reminder: we should ensure setVersion() and any other legacy/nonstandard APIs generate console warnings, or have webkit prefixes. (I can't think of any other that setVersion() we haven't already done this for.)
By the way, would you be willing to add a histogram to compare prefixed use of IDB to unprefixed use? (Like we have for webktiSlice: http://trac.webkit.org/browser/trunk/Source/WebCore/fileapi/Blob.cpp#L89) Note: That might mean that you won't be able to use the slick ImplementedAs IDL attribute. Also, should we show a deprecation message encouraging folks to move off the prefixed API?
Created attachment 164992 [details] Patch
jsbell, abarth, anyone, comments? After taking a look at the generated code, it appears that [ImplementedAs=indexedDB,V8MeasureAs=PrefixedIndexedDB] will do what we want.
Comment on attachment 164992 [details] Patch lgtm
Created attachment 165401 [details] Patch for landing
Comment on attachment 165401 [details] Patch for landing Clearing flags on attachment: 165401 Committed r129385: <http://trac.webkit.org/changeset/129385>
All reviewed patches have been landed. Closing bug.