Bug 96438

Summary: fast/spatial-navigation test fail on mac-wk2
Product: WebKit Reporter: Stephanie Lewis <slewis>
Component: WebKit2Assignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, jberlin, kenneth, mikhail.pozdnyakov, slewis, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar, MakingBotsRed
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephanie Lewis
Reported 2012-09-11 15:48:20 PDT
After https://bugs.webkit.org/show_bug.cgi?id=96269 which implemented testRunner.setSpatialNavigationEnabled the fast/spatial-navigation tests are still failing on Mac WK2.
Attachments
Patch (1.45 KB, patch)
2013-07-29 07:19 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-09-11 15:49:02 PDT
<rdar://problem/12280331>
Tim Horton
Comment 2 2012-09-11 16:33:04 PDT
Related to https://bugs.webkit.org/show_bug.cgi?id=96226?
Stephanie Lewis
Comment 3 2012-09-11 16:34:35 PDT
Skipped in http://trac.webkit.org/changeset/128240
Jessie Berlin
Comment 4 2013-04-18 11:01:41 PDT
The spatial navigation tests all pass for me on Mountain Lion WK2 Debug. I think they were fixed by the fixes for https://bugs.webkit.org/show_bug.cgi?id=96226. I am going to unskip them. *** This bug has been marked as a duplicate of bug 96226 ***
Jessie Berlin
Comment 5 2013-04-18 11:30:38 PDT
Nevermind, I was running wk1 tests by accident. Reopening.
Antoine Quint
Comment 6 2013-07-29 07:18:29 PDT
This test passes for me on 10.9, I can't tell if it passes on WK1 or Mountain Lion platforms as it stands, but I think we should be able to unskip it on Mac.
Antoine Quint
Comment 7 2013-07-29 07:19:37 PDT
Created attachment 207653 [details] Patch
Antonio Gomes
Comment 8 2013-07-29 07:27:58 PDT
Comment on attachment 207653 [details] Patch It should pass since the switch to use Internals.
WebKit Commit Bot
Comment 9 2013-07-29 08:29:44 PDT
Comment on attachment 207653 [details] Patch Clearing flags on attachment: 207653 Committed r153425: <http://trac.webkit.org/changeset/153425>
WebKit Commit Bot
Comment 10 2013-07-29 08:29:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.