WebKitTestRunner needs testRunner.setSpatialNavigationEnabled in order to unskip fast/spatial-navigation
Created attachment 163122 [details] patch
Comment on attachment 163122 [details] patch Rejecting attachment 163122 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13798822
(In reply to comment #2) > (From update of attachment 163122 [details]) > Rejecting attachment 163122 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 > > ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). > > Full output: http://queues.webkit.org/results/13798822 Looks weird.
Comment on attachment 163122 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=163122&action=review > Tools/ChangeLog:5 > + Missing Reviewed by NOBODY line.
Comment on attachment 163122 [details] patch Rejecting attachment 163122 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13810584
Created attachment 163326 [details] to be landed
Comment on attachment 163326 [details] to be landed Rejecting attachment 163326 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: KitTestRunner/InjectedBundle/InjectedBundle.cpp.rej patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp Hunk #1 succeeded at 683 with fuzz 1 (offset 5 lines). patching file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h Hunk #1 FAILED at 106. 1 out of 1 hunk FAILED -- saving rejects to file Tools/WebKitTestRunner/InjectedBundle/TestRunner.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/13819289
Created attachment 163338 [details] rebased
Comment on attachment 163338 [details] rebased Rejecting attachment 163338 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154697 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13828076
Created attachment 163350 [details] another attempt removed OOOPS from ChangeLog
Comment on attachment 163350 [details] another attempt Clearing flags on attachment: 163350 Committed r128186: <http://trac.webkit.org/changeset/128186>
All reviewed patches have been landed. Closing bug.