fast/spatial-navigation tests was unskipped by https://trac.webkit.org/changeset/128186 but it this one fail with timeout on Qt WK2: --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/spatial-navigation/snav-media-elements-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/spatial-navigation/snav-media-elements-actual.txt @@ -1,28 +1,2 @@ -This is a link start of Test. +FAIL: Timed out waiting for notifyDone to be called -This is a link i2. - -This is a link i4. - -This is a link i6. - -This is a link i8. - -This is a link End of Test. - -PASS gFocusedDocument.activeElement.getAttribute("id") is "start" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v1" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i2" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v3" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i4" -PASS gFocusedDocument.activeElement.getAttribute("id") is "v5" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i6" -PASS gFocusedDocument.activeElement.getAttribute("id") is "a7" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" -PASS gFocusedDocument.activeElement.getAttribute("id") is "end" -PASS gFocusedDocument.activeElement.getAttribute("id") is "i8" -PASS gFocusedDocument.activeElement.getAttribute("id") is "end" -PASS successfullyParsed is true - -TEST COMPLETE -This tests that a media elements ie: <Audio> or <video>, without tabindex are able to be reached through keyboard access
I skipped it - https://trac.webkit.org/changeset/128193
It does not timeout here. Could it be flaky?
Created attachment 163599 [details] Patch
(In reply to comment #3) > Created an attachment (id=163599) [details] > Patch I couldn't make it timeout on my machine, but perhaps this helps?
Antonio, can you help us review this change to the spatial navigation tests? :)
Comment on attachment 163599 [details] Patch Clearing flags on attachment: 163599 Committed r129103: <http://trac.webkit.org/changeset/129103>
All reviewed patches have been landed. Closing bug.
Reopen, because it still fails with timeout.
(In reply to comment #8) > Reopen, because it still fails with timeout. ... and skipped again to paint the bot green - https://trac.webkit.org/changeset/129475
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.