Summary: | [EFL] Enable MEDIA_STREAM | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | cdumez, lucas.de.marchi | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2012-09-06 19:36:28 PDT
Created attachment 162658 [details]
the snip error info
../../../lib/libwebcore_efl.a(MediaStreamTrack.cpp.o): In function `WebCore::MediaStreamTrack::~MediaStreamTrack()':
MediaStreamTrack.cpp:(.text+0x4f5): undefined reference to `WebCore::MediaStreamSource::removeObserver(WebCore::MediaStreamSource::Observer*)'
../../../lib/libwebcore_efl.a(MediaStreamTrack.cpp.o): In function `WebCore::MediaStreamTrack::MediaStreamTrack(WebCore::ScriptExecutionContext*, WTF::PassRefPtr<WebCore::MediaStreamDescriptor>, WebCore::MediaStreamComponent*)':
the problem is due to Source/WebCore/platform/mediastream/MediaStreamSource.cpp not enabled,
and when compare to Source/WebCore/GNUmakefile.list.am, Source/WebCore/CMakeList.txt missing a few files from directory Source/WebCore/platform/mediastream/
Created attachment 162662 [details]
add missing files fix this problem
I've blindly copy missing files from GNUMakefile.list.am, adjust it if you think necessary
(In reply to comment #3) Dennis Lan, you should read webkit contribution page first. Your patch doesn't follow webkit patch style. http://www.webkit.org/coding/contributing.html I think that your patch is just for fixing build break. So, I think you have to submit your patch to Bug 96063 instead. This bug needs to do something further to enable MEDIA_STREAM feature. Yes, right(In reply to comment #5) > Duplicate of Bug 87662? Ah, yes, right. *** This bug has been marked as a duplicate of bug 87662 *** |