Summary: | [chromium] Remove unused WebGestureEvent fields | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Rick Byers <rbyers> | ||||||
Component: | WebKit API | Assignee: | Rick Byers <rbyers> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, aelias, dglazkov, fishd, jamesr, rjkroege, tkent+wkapi, trchen, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 95573, 95996 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Rick Byers
2012-08-30 13:43:52 PDT
The part this change depends on has been split into bug 95573 Created attachment 163693 [details]
Patch
Ok, ready to take this last big step (so nobody can add any new code to write to these obsolete fields). Can someone review please - abarth? Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. LGTM, thanks. abarth can give the r+. Comment on attachment 163693 [details]
Patch
Yay! Thanks.
Comment on attachment 163693 [details] Patch Rejecting attachment 163693 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154697 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13821920 Created attachment 163708 [details]
Fix ChangeLog copy-paste error
Comment on attachment 163708 [details]
Fix ChangeLog copy-paste error
Darn, sorry - fixed duplicate 'Reviewed by NOBODY' line in ChangeLog, otherwise no changes.
Comment on attachment 163708 [details] Fix ChangeLog copy-paste error Clearing flags on attachment: 163708 Committed r128378: <http://trac.webkit.org/changeset/128378> All reviewed patches have been landed. Closing bug. |