Bug 94483

Summary: [EFL] Enable CSS Text Decoration by default
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: bruno.abinader, cdumez, g.czajkowski, gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 58491    
Attachments:
Description Flags
Patch none

Description Thiago Marcos P. Santos 2012-08-20 08:53:20 PDT 
The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions.
Comment 1 Bruno Abinader (history only) 2012-08-20 08:58:18 PDT 
(In reply to comment #0)
> The feature is relatively new, but the EFL port has a big interest on it. IMO the best way of making this implementation mature is to add it to our continuous integration system (aka. bots) and make sure the tests are passing and keep the eyes opened for regressions.

Awesome news, Thiago! I'll be taking care of EFL build on my CSS3 Text Decoration implementations. So far, in terms of implementation, only "wavy" text decoration style platform support (Cairo-specific bug 94110) and "-webkit-text-decoration-skip" (bug 92801). Other implementations are now pending review / commit-queue flags.
Comment 2 Thiago Marcos P. Santos 2012-08-20 08:58:44 PDT 
Created attachment 159442 [details]
Patch
Comment 3 Thiago Marcos P. Santos 2012-08-20 09:01:23 PDT 
Comment on attachment 159442 [details]
Patch

Removing cq?. Will give time to other developers from the community to comment on this bug.
Comment 4 Chris Dumez 2012-08-20 12:26:09 PDT 
Looks good. Thanks Thiago.
Comment 5 Grzegorz Czajkowski 2012-08-21 00:11:27 PDT 
It's good idea to enable this feature especially if we have Bruno's support.

BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)?
Comment 6 Thiago Marcos P. Santos 2012-08-21 04:52:33 PDT 
(In reply to comment #5)
> It's good idea to enable this feature especially if we have Bruno's support.
> 
> BTW, did you check EWebLauncher/MiniBrowser behavior with this feature? Doesn't it cause any issues (for single and tiled backing stores in case of EWebLauncher)?

Tested MiniBrowser, EWebLauncher and ran a complete layout tests after enabling it locally. No regressions found.
Comment 7 WebKit Review Bot 2012-08-21 15:34:57 PDT 
Comment on attachment 159442 [details]
Patch

Clearing flags on attachment: 159442

Committed r126197: <http://trac.webkit.org/changeset/126197>
Comment 8 WebKit Review Bot 2012-08-21 15:35:01 PDT 
All reviewed patches have been landed.  Closing bug.