Bug 94166

Summary: [Forms] Wheel event support in multiple fields time input UI
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 93928, 94172, 94186    
Bug Blocks: 88970    
Attachments:
Description Flags
Patch 1
none
A layout test for wheel event handling in multiple fields time input UI
none
Patch 2 none

Description yosin 2012-08-15 18:37:05 PDT
The spin button in multiple fields time input UI should support wheel event as the spin button of number input type.
Comment 1 yosin 2012-08-15 19:09:56 PDT
Created attachment 158689 [details]
Patch 1
Comment 2 yosin 2012-08-15 19:12:52 PDT
Created attachment 158690 [details]
A layout test for wheel event handling in multiple fields time input UI

This is a layout test for wheel event handling in multiple fields time input UI.

This test is derived from fast/forms/number/number-wheel.html.
I'll do re-factoring to share code between number input type and time input type.
Comment 3 yosin 2012-08-15 19:13:47 PDT
Comment on attachment 158689 [details]
Patch 1

Could you review this patch?
Thanks in advance.

I attached a test I used for testing this patch.
Comment 4 Kent Tamura 2012-08-15 19:30:00 PDT
Comment on attachment 158689 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=158689&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests. Test will be added when runtime feature flags enabled.

DRT already enables the runtime flag.  We should have a test.
Comment 5 yosin 2012-08-16 00:15:27 PDT
Created attachment 158727 [details]
Patch 2
Comment 6 yosin 2012-08-16 00:16:26 PDT
Comment on attachment 158727 [details]
Patch 2

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Add a test.
Comment 7 Kent Tamura 2012-08-16 00:32:02 PDT
Comment on attachment 158727 [details]
Patch 2

ok
Comment 8 yosin 2012-08-16 00:34:25 PDT
Comment on attachment 158727 [details]
Patch 2

Clearing flags on attachment: 158727

Committed r125754: <http://trac.webkit.org/changeset/125754>
Comment 9 yosin 2012-08-16 00:34:30 PDT
All reviewed patches have been landed.  Closing bug.