In current implementation, wheel event handler is implemented in TextFieldInputType and called from NumberInputType and BaseDateTimeInputType class. To shared wheel event handler code within them and multiple field time UI, I would like to move implementation of wheel event handler into SpinButton class.
Created attachment 158230 [details] Patch 1
Comment on attachment 158230 [details] Patch 1 Could you review this patch Thanks in advance.
Comment on attachment 158230 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=158230&action=review > Source/WebCore/html/shadow/TextControlInnerElements.cpp:354 > + HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowHost()); > + if (input->disabled() || input->readOnly() || !input->focused()) > + return; > + You wanted to remove HTMLInputElement dependency from SpinButtonElement, right?
(In reply to comment #3) > (From update of attachment 158230 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=158230&action=review > > > Source/WebCore/html/shadow/TextControlInnerElements.cpp:354 > > + HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowHost()); > > + if (input->disabled() || input->readOnly() || !input->focused()) > > + return; > > + > > You wanted to remove HTMLInputElement dependency from SpinButtonElement, right? Yes, I really want to do so. I would like to make this patch to be handling wheel event only. I'll free SpinButtonElement ffrom HTMLInputElement dependency in other patches like: Patch 1. Do svn copy TextControllInnerElements.{cpp,h} to SpinButtonElement.{cpp,h} Patch 2. Rename SpinButtonActionHandler to SpinButtonElementOwner with willHandleStepAction()
Created attachment 158249 [details] Patch 2
Comment on attachment 158249 [details] Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * (SpinButtonElement::forwardEvent): Check SpinButtonElement rendered(== calling renderBox() != nullptr)
Comment on attachment 158249 [details] Patch 2 ok
Comment on attachment 158249 [details] Patch 2 Clearing flags on attachment: 158249 Committed r125522: <http://trac.webkit.org/changeset/125522>
All reviewed patches have been landed. Closing bug.