Bug 94186 - [Tests] Disable fast/forms/time-multiple-fields tests for ports which don't enable multiple fields time input UI feature
Summary: [Tests] Disable fast/forms/time-multiple-fields tests for ports which don't e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 94166
  Show dependency tree / graph
 
Reported: 2012-08-15 22:00 PDT by yosin
Modified: 2012-08-15 22:59 PDT (History)
4 users (show)

See Also:

Attachments
Patch 1 (5.19 KB, patch)
2012-08-15 22:13 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (5.20 KB, patch)
2012-08-15 22:15 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (5.55 KB, patch)
2012-08-15 22:47 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-15 22:00:47 PDT 
Tests in fast/forms/time-multiple-fields/ are ports enabling both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
These tests should be skipped for ports which don't enable multiple field time input UI.
Comment 1 yosin 2012-08-15 22:13:11 PDT 
Created attachment 158709 [details]
Patch 1
Comment 2 yosin 2012-08-15 22:15:30 PDT 
Created attachment 158711 [details]
Patch 2
Comment 3 yosin 2012-08-15 22:16:03 PDT 
Comment on attachment 158711 [details]
Patch 2

Could you review this patch?
Thanks in advance.
Comment 4 Raphael Kubo da Costa (:rakuco) 2012-08-15 22:42:00 PDT 
I'd appreciate it if you could update TestExpectations instead of Skipped for the EFL port.
Comment 5 yosin 2012-08-15 22:47:35 PDT 
Created attachment 158714 [details]
Patch 3
Comment 6 yosin 2012-08-15 22:48:40 PDT 
Comment on attachment 158714 [details]
Patch 3

Could you review this patch?
Thanks in advance.

= Changes since the last review =
* Change platform/efl/TestExpectations instead of Skipped
Comment 7 Kent Tamura 2012-08-15 22:58:19 PDT 
Comment on attachment 158714 [details]
Patch 3

ok
Comment 8 yosin 2012-08-15 22:59:51 PDT 
Comment on attachment 158714 [details]
Patch 3

Clearing flags on attachment: 158714

Committed r125748: <http://trac.webkit.org/changeset/125748>
Comment 9 yosin 2012-08-15 22:59:58 PDT 
All reviewed patches have been landed.  Closing bug.