| Summary: | [V8] Remove V8BindingHelpers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||
| Component: | WebCore JavaScript | Assignee: | Kentaro Hara <haraken> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, gyuyoung.kim, japhet, rakuco, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 93095 | ||||||
| Attachments: |
|
||||||
Created attachment 157943 [details]
Patch
Comment on attachment 157943 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157943&action=review > Source/WebCore/bindings/v8/NPV8Object.cpp:67 > + if (!domWindow || !domWindow->frame() || domWindow != domWindow->frame()->domWindow()) This line of code is so broken. I'll fix it as part of Bug 75793. Committed r125479: <http://trac.webkit.org/changeset/125479> |
V8BindingHelpers contains toV8Context() and toV8Proxy(), which are used by NPV8Object.cpp only. (1) Move these methods to NPV8Object.cpp as static methods. (2) Remove V8BindingHelpers.{h,cpp}.