Bug 93589

Summary: REGRESSION(r125147): Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: SVGAssignee: Hajime Morrita <morrita>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, fmalita, morrita, pvollan, sabouhallawa, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=153498
Attachments:
Description Flags
Patch zimmermann: review+, webkit.review.bot: commit-queue-

Description Takashi Toyoshima 2012-08-09 01:04:22 PDT 
The following layout test is failing on Chromium Snow Leopard (debug).

svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg

I'll mark this test as slow.
Comment 1 Takashi Toyoshima 2012-08-09 01:11:19 PDT 
http://trac.webkit.org/changeset/125161
Comment 2 Florin Malita 2012-08-09 11:48:16 PDT 
Looks like it's still timing out, on Linux too. Marking as such: http://trac.webkit.org/changeset/125190
Comment 3 Alexey Proskuryakov 2012-09-13 13:48:06 PDT 
This test is very flaky on Mac as well.
Comment 4 Kent Tamura 2012-09-13 20:38:35 PDT 

*** This bug has been marked as a duplicate of bug 96723 ***
Comment 5 Kent Tamura 2012-09-13 20:39:38 PDT 
oops, this shouldn't be a dupe.
Comment 6 Kent Tamura 2012-09-13 20:39:55 PDT 
*** Bug 96723 has been marked as a duplicate of this bug. ***
Comment 7 Alexey Proskuryakov 2012-09-18 12:37:07 PDT 
Skipped on Mac in <http://trac.webkit.org/r128922>. Mac failure:

--- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-expected.txt
+++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-actual.txt
@@ -1,8 +1,9 @@
+FAIL: Timed out waiting for notifyDone to be called
 Test changing externalResourcesRequired after inserting the element into the tree.
 Test 1: PASS
 
-Test 2: PASS
+Test 2: FAIL: onload fired too late. External resource already completed loading
 
-Test 3: PASS
+Test 3: DID NOT EXECUTE
 
-Test 4: PASS
+Test 4: DID NOT EXECUTE
Comment 8 Hajime Morrita 2012-11-04 20:04:14 PST 
*** Bug 101176 has been marked as a duplicate of this bug. ***
Comment 9 Hajime Morrita 2012-11-05 22:37:57 PST 
Created attachment 172490 [details]
Patch
Comment 10 Hajime Morrita 2012-11-05 22:38:50 PST 
CCing Zimmermann to hear his opinion.
Comment 11 Nikolas Zimmermann 2012-11-09 23:12:30 PST 
This flakiness is known since age - multiple attempts at trying to track it down failed. If you have an idea what could cause these sporadic errors, do shout :-)
Comment 12 Nikolas Zimmermann 2012-11-09 23:13:24 PST 
Comment on attachment 172490 [details]
Patch

Aha, didn't realize the SVGLoad event timing change. So r=me, this is the right way to go!
Comment 13 Hajime Morrita 2012-11-11 16:46:57 PST 
Comment on attachment 172490 [details]
Patch

Thanks ;-)
Comment 14 WebKit Review Bot 2012-11-11 17:15:14 PST 
Comment on attachment 172490 [details]
Patch

Rejecting attachment 172490 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/sfntly/cpp/src --revision 134 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 134.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14813133
Comment 15 Per Arne Vollan 2017-07-28 09:54:07 PDT 
This test is also a flaky timeout on Windows, updated test expectations in <https://trac.webkit.org/changeset/220002/webkit>.
Comment 16 Said Abou-Hallawa 2019-10-17 18:20:27 PDT 

*** This bug has been marked as a duplicate of bug 191293 ***