Bug 93589 – REGRESSION(r125147): Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing

• Component: SVG
• Status: RESOLVED DUPLICATE

[Takashi Toyoshima]

The following layout test is failing on Chromium Snow Leopard (debug).

svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg

I'll mark this test as slow.

[Takashi Toyoshima]

http://trac.webkit.org/changeset/125161

[Florin Malita]

Looks like it's still timing out, on Linux too. Marking as such: http://trac.webkit.org/changeset/125190

[Alexey Proskuryakov]

This test is very flaky on Mac as well.

[Kent Tamura]

*** This bug has been marked as a duplicate of bug 96723 ***

[Kent Tamura]

oops, this shouldn't be a dupe.

[Kent Tamura]

*** Bug 96723 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Skipped on Mac in <http://trac.webkit.org/r128922>. Mac failure:

--- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-expected.txt
+++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading-actual.txt
@@ -1,8 +1,9 @@
+FAIL: Timed out waiting for notifyDone to be called
 Test changing externalResourcesRequired after inserting the element into the tree.
 Test 1: PASS
 
-Test 2: PASS
+Test 2: FAIL: onload fired too late. External resource already completed loading
 
-Test 3: PASS
+Test 3: DID NOT EXECUTE
 
-Test 4: PASS
+Test 4: DID NOT EXECUTE

[Hajime Morrita]

*** Bug 101176 has been marked as a duplicate of this bug. ***

[Hajime Morrita]

Created attachment 172490 [details]
Patch

[Hajime Morrita]

CCing Zimmermann to hear his opinion.

[Nikolas Zimmermann]

This flakiness is known since age - multiple attempts at trying to track it down failed. If you have an idea what could cause these sporadic errors, do shout :-)

[Nikolas Zimmermann]

Comment on attachment 172490 [details]
Patch

Aha, didn't realize the SVGLoad event timing change. So r=me, this is the right way to go!

[Hajime Morrita]

Comment on attachment 172490 [details]
Patch

Thanks ;-)

[WebKit Review Bot]

Comment on attachment 172490 [details]
Patch

Rejecting attachment 172490 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/sfntly/cpp/src --revision 134 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
45>At revision 134.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14813133

[Per Arne Vollan]

This test is also a flaky timeout on Windows, updated test expectations in <https://trac.webkit.org/changeset/220002/webkit>.

[Said Abou-Hallawa]

*** This bug has been marked as a duplicate of bug 191293 ***