Bug 191293 – [SVG2]: Remove the SVGExternalResourcesRequired interface

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

The specs page is: https://www.w3.org/TR/SVG2/

The affected classes are:

SVGAElement
SVGAnimationElement
SVGCircleElement
SVGClipPathElement
SVGCursorElement
SVGDefsElement
SVGEllipseElement
SVGFEImageElement
SVGFilterElement
SVGFontElement
SVGForeignObjectElement
SVGGElement
SVGGradientElement
SVGImageElement
SVGLineElement
SVGMarkerElement
SVGMaskElement
SVGMPathElement
SVGPathElement
SVGPatternElement
SVGPolyElement
SVGRectElement
SVGScriptElement
SVGSVGElement
SVGSwitchElement
SVGSymbolElement
SVGTextContentElement
SVGUseElement
SVGViewElement

[Said Abou-Hallawa]

Created attachment 381257 [details]
Patch

[Said Abou-Hallawa]

*** Bug 93589 has been marked as a duplicate of this bug. ***

[Said Abou-Hallawa]

*** Bug 153498 has been marked as a duplicate of this bug. ***

[Said Abou-Hallawa]

*** Bug 174240 has been marked as a duplicate of this bug. ***

[EWS Watchlist]

Comment on attachment 381257 [details]
Patch

Attachment 381257 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13145576

New failing tests:
fast/html/marquee-reparent-check.html
svg/custom/image-load-event.html
fast/dom/focus-style-resolution.html
fast/dom/crash-moving-subtree-between-documents.html
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg

[EWS Watchlist]

Created attachment 381264 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Said Abou-Hallawa]

Created attachment 381323 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 381323 [details]
Patch

Clearing flags on attachment: 381323

Committed r251318: <https://trac.webkit.org/changeset/251318>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/56426747>

[Carlos Alberto Lopez Perez]

Comment on attachment 381323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381323&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +        * web-platform-tests/svg/import/types-dom-04-b-manual.svg:
> +        Use the preserveAlpha property of <feConvolveMatrix> element to test
> +        SVGAnimatedBoolean.

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:97
>        </filter>
> +      <filter>
> +        <feConvolveMatrix id='feConvolveMatrix' order="1" kernelMatrix="1"/>
> +      </filter>

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:111
>            marker = $('marker'),
>            svg = $('svg'),
>            feTurbulence = $('feTurbulence');
> +          feConvolveMatrix = $('feConvolveMatrix');
>  
>        function expect_exception(id, fn, code) {
>          try {

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:203
>           },
>           true);
>  
> -      // SVGAnimatedBoolean: externalResourcesRequired on svg
> +      // SVGAnimatedBoolean: preserveAlpha on svg
>        expect_value
>          ('r8',
>           function() {
> -           return !svg.externalResourcesRequired.baseVal
> -               && (svg.setAttribute('externalResourcesRequired', 'true'), svg.externalResourcesRequired.baseVal);
> +           return !feConvolveMatrix.preserveAlpha.baseVal
> +               && (feConvolveMatrix.setAttribute('preserveAlpha', 'true'), feConvolveMatrix.preserveAlpha.baseVal);
>           },
>           true);

Were the changes done to this test proposed to be merged back to WPT?
I don't see this changes on WPT <https://github.com/web-platform-tests/wpt/blob/master/svg/import/types-dom-04-b-manual.svg?short_path=37df625>.
Is there any open PR for this?