Bug 191293 - [SVG2]: Remove the SVGExternalResourcesRequired interface
Summary: [SVG2]: Remove the SVGExternalResourcesRequired interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
: 93589 153498 174240 (view as bug list)
Depends on:
Blocks: 191292
  Show dependency treegraph
 
Reported: 2018-11-05 18:57 PST by Said Abou-Hallawa
Modified: 2020-03-16 21:53 PDT (History)
23 users (show)

See Also:


Attachments
Patch (216.67 KB, patch)
2019-10-17 18:19 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews215 for win-future (13.72 MB, application/zip)
2019-10-17 20:26 PDT, EWS Watchlist
no flags Details
Patch (141.07 KB, patch)
2019-10-18 12:59 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2018-11-05 18:57:20 PST
The specs page is: https://www.w3.org/TR/SVG2/

The affected classes are:

SVGAElement
SVGAnimationElement
SVGCircleElement
SVGClipPathElement
SVGCursorElement
SVGDefsElement
SVGEllipseElement
SVGFEImageElement
SVGFilterElement
SVGFontElement
SVGForeignObjectElement
SVGGElement
SVGGradientElement
SVGImageElement
SVGLineElement
SVGMarkerElement
SVGMaskElement
SVGMPathElement
SVGPathElement
SVGPatternElement
SVGPolyElement
SVGRectElement
SVGScriptElement
SVGSVGElement
SVGSwitchElement
SVGSymbolElement
SVGTextContentElement
SVGUseElement
SVGViewElement
Comment 1 Said Abou-Hallawa 2019-10-17 18:19:46 PDT
Created attachment 381257 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-10-17 18:20:27 PDT
*** Bug 93589 has been marked as a duplicate of this bug. ***
Comment 3 Said Abou-Hallawa 2019-10-17 18:20:48 PDT
*** Bug 153498 has been marked as a duplicate of this bug. ***
Comment 4 Said Abou-Hallawa 2019-10-17 18:21:02 PDT
*** Bug 174240 has been marked as a duplicate of this bug. ***
Comment 5 EWS Watchlist 2019-10-17 20:26:14 PDT
Comment on attachment 381257 [details]
Patch

Attachment 381257 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/13145576

New failing tests:
fast/html/marquee-reparent-check.html
svg/custom/image-load-event.html
fast/dom/focus-style-resolution.html
fast/dom/crash-moving-subtree-between-documents.html
svg/W3C-SVG-1.1-SE/types-dom-04-b.svg
Comment 6 EWS Watchlist 2019-10-17 20:26:16 PDT
Created attachment 381264 [details]
Archive of layout-test-results from ews215 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews215  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit
Comment 7 Said Abou-Hallawa 2019-10-18 12:59:49 PDT
Created attachment 381323 [details]
Patch
Comment 8 WebKit Commit Bot 2019-10-18 18:18:26 PDT
Comment on attachment 381323 [details]
Patch

Clearing flags on attachment: 381323

Committed r251318: <https://trac.webkit.org/changeset/251318>
Comment 9 WebKit Commit Bot 2019-10-18 18:18:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-10-18 18:19:21 PDT
<rdar://problem/56426747>
Comment 11 Carlos Alberto Lopez Perez 2020-03-16 21:53:24 PDT
Comment on attachment 381323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=381323&action=review

> LayoutTests/imported/w3c/ChangeLog:10
> +        * web-platform-tests/svg/import/types-dom-04-b-manual.svg:
> +        Use the preserveAlpha property of <feConvolveMatrix> element to test
> +        SVGAnimatedBoolean.

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:97
>        </filter>
> +      <filter>
> +        <feConvolveMatrix id='feConvolveMatrix' order="1" kernelMatrix="1"/>
> +      </filter>

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:111
>            marker = $('marker'),
>            svg = $('svg'),
>            feTurbulence = $('feTurbulence');
> +          feConvolveMatrix = $('feConvolveMatrix');
>  
>        function expect_exception(id, fn, code) {
>          try {

...

> LayoutTests/imported/w3c/web-platform-tests/svg/import/types-dom-04-b-manual.svg:203
>           },
>           true);
>  
> -      // SVGAnimatedBoolean: externalResourcesRequired on svg
> +      // SVGAnimatedBoolean: preserveAlpha on svg
>        expect_value
>          ('r8',
>           function() {
> -           return !svg.externalResourcesRequired.baseVal
> -               && (svg.setAttribute('externalResourcesRequired', 'true'), svg.externalResourcesRequired.baseVal);
> +           return !feConvolveMatrix.preserveAlpha.baseVal
> +               && (feConvolveMatrix.setAttribute('preserveAlpha', 'true'), feConvolveMatrix.preserveAlpha.baseVal);
>           },
>           true);

Were the changes done to this test proposed to be merged back to WPT?
I don't see this changes on WPT <https://github.com/web-platform-tests/wpt/blob/master/svg/import/types-dom-04-b-manual.svg?short_path=37df625>.
Is there any open PR for this?