Bug 93454 – [WK2] [WTR] Provide Resource Response dumping.

• Component: WebKit2
• Status: RESOLVED FIXED

[Mikhail Pozdnyakov]

Several layout tests (fast/dom/HTMLLinkElement) are failing on WK2 with :
CONSOLE MESSAGE: line 15: TypeError: 'undefined' is not a function (evaluating 'testRunner.dumpResourceResponseMIMETypes()')

So Resource Response dumping is to be provided. 
To provide Resource Response dumping several new functions should be added to 
WKURL and WKURLResponse WK2 shared API.

[Mikhail Pozdnyakov]

Created attachment 157159 [details]
patch

[Chris Dumez]

Comment on attachment 157159 [details]
patch

LGTM, thanks.

[Kenneth Rohde Christiansen]

Comment on attachment 157159 [details]
patch

nice

[WebKit Review Bot]

Comment on attachment 157159 [details]
patch

Rejecting attachment 157159 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
unner/InjectedBundle/InjectedBundlePage.cpp
patching file Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp
patching file Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h
Hunk #2 FAILED at 163.
1 out of 3 hunks FAILED -- saving rejects to file Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13458230

[Mikhail Pozdnyakov]

Created attachment 157192 [details]
to be landed

[WebKit Review Bot]

Comment on attachment 157192 [details]
to be landed

Clearing flags on attachment: 157192

Committed r125031: <http://trac.webkit.org/changeset/125031>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

We already had a bug for this, bug 42543.

There is a bunch of tests skipped on WK2 due to this, which should be unskipped now. That would have validated correctness of output, too.

Kenneth, since you reviewed this patch, can you please work with Mikhail to make this happen?

[Alexey Proskuryakov]

*** Bug 42543 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

Comment on attachment 157192 [details]
to be landed

View in context: https://bugs.webkit.org/attachment.cgi?id=157192&action=review

> Source/WebKit2/Shared/API/c/WKURLResponse.cpp:45
> +WKStringRef WKURLResponseCopyMimeType(WKURLResponseRef responseRef)

Coding style violation - MIME should be all caps. Since this part of API, it's super important to have this right, please make a follow-up fix ASAP.

> Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:81
> +    void dumpProgressFinishedCallback() { setShouldDumpProgressFinishedCallback(true); }    

Trailing whitespace accidentally added here.

[Mikhail Pozdnyakov]

(In reply to comment #10)
> (From update of attachment 157192 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=157192&action=review
> 
> > Source/WebKit2/Shared/API/c/WKURLResponse.cpp:45
> > +WKStringRef WKURLResponseCopyMimeType(WKURLResponseRef responseRef)
> 
> Coding style violation - MIME should be all caps. Since this part of API, it's super important to have this right, please make a follow-up fix ASAP.
> 
> > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:81
> > +    void dumpProgressFinishedCallback() { setShouldDumpProgressFinishedCallback(true); }    
> 
> Trailing whitespace accidentally added here.

Sorry for hassle. Here is follow-up fix:
https://bugs.webkit.org/show_bug.cgi?id=93503

[Alexey Proskuryakov]

Thank you!

Please take care of Skipped list, too (per comment 8).

[Mikhail Pozdnyakov]

(In reply to comment #12)
> Thank you!
> 
> Please take care of Skipped list, too (per comment 8).

Addressed here: https://bugs.webkit.org/show_bug.cgi?id=93638.