Bug 93638 – [WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Mikhail Pozdnyakov]

Tests requiring layoutTestController.dumpResourceResponseMIMETypes can be unskipped as https://bugs.webkit.org/show_bug.cgi?id=93454
is landed.

[Mikhail Pozdnyakov]

Created attachment 157511 [details]
patch

Unfortunately I do not have an opportunity to check that platform/mac/.. tests pass, so keep them skipped so far.

[Alexey Proskuryakov]

Tests 2 and 3 passed for me on Mac, but the first one failed:

-example-dng.dng has MIME type application/octet-stream
+example-dng.dng has MIME type image/x-adobe-dng

This probably depends on whether one has Adobe software installed. It's not a very useful test overall, as it mostly reports what lower level OS components tell us, not about anything in WebKit.

[WebKit Review Bot]

Comment on attachment 157511 [details]
patch

Rejecting attachment 157511 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/PerformanceTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13457937

[Alexey Proskuryakov]

The failure looks like a commit queue issue to me.

[Adam Barth]

Interesting.  The regexp for "Unreviewed" must be too tight.

[Eric Seidel (no email)]

Maybe something changed recently in the ChangeLog.py class.  Or maybe this particular instance just got confused somehow.

[Alexey Proskuryakov]

Someone pointed out on IRC that this is not a unique occurrence, see <https://bugs.webkit.org/show_bug.cgi?id=90959#c44>.

[Eric Seidel (no email)]

The checkout got corrupted on one of the instances.  Adam is fixing.

[WebKit Review Bot]

Comment on attachment 157511 [details]
patch

Clearing flags on attachment: 157511

Committed r125215: <http://trac.webkit.org/changeset/125215>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.