Bug 93638 - [WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes
Summary: [WK2] Unskip tests requiring layoutTestController.dumpResourceResponseMIMETypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 12:11 PDT by Mikhail Pozdnyakov
Modified: 2012-08-09 15:51 PDT (History)
6 users (show)

See Also:


Attachments
patch (2.67 KB, patch)
2012-08-09 12:18 PDT, Mikhail Pozdnyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-08-09 12:11:34 PDT
Tests requiring layoutTestController.dumpResourceResponseMIMETypes can be unskipped as https://bugs.webkit.org/show_bug.cgi?id=93454
is landed.
Comment 1 Mikhail Pozdnyakov 2012-08-09 12:18:38 PDT
Created attachment 157511 [details]
patch

Unfortunately I do not have an opportunity to check that platform/mac/.. tests pass, so keep them skipped so far.
Comment 2 Alexey Proskuryakov 2012-08-09 13:00:14 PDT
Tests 2 and 3 passed for me on Mac, but the first one failed:

-example-dng.dng has MIME type application/octet-stream
+example-dng.dng has MIME type image/x-adobe-dng

This probably depends on whether one has Adobe software installed. It's not a very useful test overall, as it mostly reports what lower level OS components tell us, not about anything in WebKit.
Comment 3 WebKit Review Bot 2012-08-09 13:12:15 PDT
Comment on attachment 157511 [details]
patch

Rejecting attachment 157511 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/PerformanceTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13457937
Comment 4 Alexey Proskuryakov 2012-08-09 13:30:10 PDT
The failure looks like a commit queue issue to me.
Comment 5 Adam Barth 2012-08-09 13:33:30 PDT
Interesting.  The regexp for "Unreviewed" must be too tight.
Comment 6 Eric Seidel (no email) 2012-08-09 13:37:41 PDT
Maybe something changed recently in the ChangeLog.py class.  Or maybe this particular instance just got confused somehow.
Comment 7 Alexey Proskuryakov 2012-08-09 13:41:06 PDT
Someone pointed out on IRC that this is not a unique occurrence, see <https://bugs.webkit.org/show_bug.cgi?id=90959#c44>.
Comment 8 Eric Seidel (no email) 2012-08-09 13:43:49 PDT
The checkout got corrupted on one of the instances.  Adam is fixing.
Comment 9 WebKit Review Bot 2012-08-09 15:51:30 PDT
Comment on attachment 157511 [details]
patch

Clearing flags on attachment: 157511

Committed r125215: <http://trac.webkit.org/changeset/125215>
Comment 10 WebKit Review Bot 2012-08-09 15:51:35 PDT
All reviewed patches have been landed.  Closing bug.