Bug 93049

Summary: V8Proxy::retrieveFrameFor*Context are used only by BindingState and should be removed as separate functions
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, eric, haraken, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75793    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2012-08-02 16:58:40 PDT
V8Proxy::retrieveFrameFor*Context are used only by BindingState and should be removed as separate functions
Attachments
Patch (7.12 KB, patch)
2012-08-02 16:59 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-02 16:59:43 PDT
Created attachment 156210 [details] Patch
Erik Arvidsson
Comment 2 2012-08-02 17:05:21 PDT
I'm using retrieveFrameForCallingContext in a patch I'm working on. What should I be using after this?
Adam Barth
Comment 3 2012-08-02 17:09:15 PDT
> I'm using retrieveFrameForCallingContext in a patch I'm working on. What should I be using after this? Bug 93038 has a bunch of examples of removing calls to retrieveFrameForCallingContext. The longer answer is that almost all callers of this function are wrong. This series of patches will result in very few places in the bindings operating in terms of Frames. Almost every instance of the type "Frame" in the bindings is wrong.
Erik Arvidsson
Comment 4 2012-08-02 18:11:06 PDT
I have a case where I need to use the calling ScriptExecutionContext for someWindow.focus(). It is needed to determine if focus should be allowed.
Adam Barth
Comment 5 2012-08-02 18:12:35 PDT
That's a prototypical example. You want activeScriptExecutionContext(BindingState*), which doesn't yet exist but will when I'm done. Almost everyone wants the activeScriptExecutionContext rather than anything having to do with a Frame.
Erik Arvidsson
Comment 6 2012-08-02 18:22:25 PDT
(In reply to comment #5) > That's a prototypical example. You want activeScriptExecutionContext(BindingState*), which doesn't yet exist but will when I'm done. Almost everyone wants the activeScriptExecutionContext rather than anything having to do with a Frame. Sounds good.
Eric Seidel (no email)
Comment 7 2012-08-02 20:27:15 PDT
Comment on attachment 156210 [details] Patch LGTM.
WebKit Review Bot
Comment 8 2012-08-02 22:32:49 PDT
Comment on attachment 156210 [details] Patch Clearing flags on attachment: 156210 Committed r124563: <http://trac.webkit.org/changeset/124563>
WebKit Review Bot
Comment 9 2012-08-02 22:32:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.