| Summary: | Export StringImpl::sizeInBytes() with WTF_EXPORT_STRING_API | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||
| Component: | Web Template Framework | Assignee: | Patrick R. Gansterer <paroga> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | morrita, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 76257 | ||||||
| Attachments: |
|
||||||
|
Description
Patrick R. Gansterer
2012-08-01 01:08:17 PDT
Created attachment 155744 [details]
Patch
Comment on attachment 155744 [details] Patch Looks good. By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate patch in some timing? I'm sorry that my suggestion there was wrong... (In reply to comment #2) > (From update of attachment 155744 [details]) > Looks good. > > By the way, Could you address https://bugs.webkit.org/show_bug.cgi?id=92624#c8 in separate > patch in some timing? I'm sorry that my suggestion there was wrong... I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-) > I'm waiting for some response from Darin currently. My plan was to create a patch with a "_PRIVATE_" in the macro name at the weekend, if there is no response until then and CC him. -> It's on my list. :-)
Sounds good :-)
Comment on attachment 155744 [details] Patch Clearing flags on attachment: 155744 Committed r124328: <http://trac.webkit.org/changeset/124328> All reviewed patches have been landed. Closing bug. |