Bug 92081

Summary:

[Tests] Re-factor some tests in fast/forms/number for sharing with other input types

Product:

WebKit

Reporter:

yosin

Component:

Tools / Tests

Assignee:

yosin

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

92083

Bug Blocks:

91805

Attachments:

Description	Flags
Patch 1	none
Patch 2	none
Patch 3	none

yosin

Reported 2012-07-24 01:38:03 PDT

Following two tests are effective for other input types: 1. number-change-type-on-focus.html Change input type during event handling 2. number-crash.html Get rid renderer object during event handling

Attachments
Patch 1 (8.78 KB, patch) 2012-07-24 03:01 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 2 (9.06 KB, patch) 2012-07-24 03:05 PDT, yosin	no flags	Details Formatted Diff Diff
Patch 3 (9.27 KB, patch) 2012-07-24 18:39 PDT, yosin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

yosin

Comment 1 2012-07-24 03:01:20 PDT

Created attachment 154002 [details] Patch 1

yosin

Comment 2 2012-07-24 03:05:46 PDT

Created attachment 154003 [details] Patch 2

yosin

Comment 3 2012-07-24 03:06:48 PDT

Comment on attachment 154003 [details] Patch 2 Could you review this patch? Thanks in advance.

Kent Tamura

Comment 4 2012-07-24 18:05:52 PDT

Comment on attachment 154003 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=154003&action=review > LayoutTests/fast/forms/resources/common-change-type-on-focus.js:3 > +function doTest(sampleId) should have more descriptive function name. > LayoutTests/fast/forms/resources/common-losing-renderer-on-click.js:1 > +function test() ditto.

yosin

Comment 5 2012-07-24 18:39:07 PDT

Created attachment 154215 [details] Patch 3

Kent Tamura

Comment 6 2012-07-24 18:41:01 PDT

Comment on attachment 154215 [details] Patch 3 ok

yosin

Comment 7 2012-07-24 18:45:32 PDT

Comment on attachment 154215 [details] Patch 3 Clearing flags on attachment: 154215 Committed r123563: <http://trac.webkit.org/changeset/123563>

yosin

Comment 8 2012-07-24 18:45:36 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.