Summary: | [WK2][EFL] Ewk_View needs to report load status changes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | kenneth, ryuan.choi, tonikitoo, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 61838, 90601 | ||||||||
Attachments: |
|
Description
Chris Dumez
2012-07-04 09:39:50 PDT
Created attachment 150818 [details]
Patch
Created attachment 150905 [details]
Patch
Rebase on master.
Comment on attachment 150905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.h:37 > * - "load,error", const Ewk_Web_Error*: reports main frame load failed. > + * - "load,finished", void: reports load finished. > * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0). > + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed. > + * - "load,provisional,redirect", void: view received redirect for provisional load. > + * - "load,provisional,started", void: view started provisional load. > * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated. Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed? (In reply to comment #3) > (From update of attachment 150905 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=150905&action=review > > > Source/WebKit2/UIProcess/API/efl/ewk_view.h:37 > > * - "load,error", const Ewk_Web_Error*: reports main frame load failed. > > + * - "load,finished", void: reports load finished. > > * - "load,progress", double*: load progress has changed (value from 0.0 to 1.0). > > + * - "load,provisional,failed", const Ewk_Web_Error*: view provisional load failed. > > + * - "load,provisional,redirect", void: view received redirect for provisional load. > > + * - "load,provisional,started", void: view started provisional load. > > * - "resource,request,new", const Ewk_Web_Resource_Request*: a resource request was initiated. > > Why do you need to mark that it is provisional? and if you get load,provisional,failed will that then be followed by load,failed? Actually, in WebKit1-EFL, we were emitting both signals "load,provisional,failed" and then "load,error" if the provisional load failed. Should we do the same thing for WebKit2-EFL? I know that Qt uses a single signal for those 2 events but this prevents the client from making the distinction if it wants to. For example, in DRT, we had to make the distinction to print the proper output. I checked GTK port as well and while they use a single signal, they have an additional "provisional" / "committed" parameter so that they can be distinguished. As you know, adding a new parameter to an EFL signal is not very convenient or nice, and I would rather use separate signals. Ok, so no "load,error" signal after the "load,provisional,failed" then? Comment on attachment 150905 [details] Patch Clearing flags on attachment: 150905 Committed r121944: <http://trac.webkit.org/changeset/121944> All reviewed patches have been landed. Closing bug. |