Bug 85838

Summary: [CMake] Add ENABLE_IFRAME_SEAMLESS flag
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric, gyuyoung.kim, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85601    
Attachments:
Description Flags
Patch
none
Patch none

Thiago Marcos P. Santos
Reported 2012-05-07 15:51:57 PDT
Add support for ENABLE_IFRAME_SEAMLESS like it was done in bug 85822.
Attachments
Patch (3.62 KB, patch)
2012-05-08 01:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.93 KB, patch)
2012-05-08 07:26 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-05-07 15:52:42 PDT
Should be enable by default for EFL, need to check for Win and Blackberry.
Thiago Marcos P. Santos
Comment 2 2012-05-07 23:08:42 PDT
*** Bug 85861 has been marked as a duplicate of this bug. ***
Chris Dumez
Comment 3 2012-05-07 23:10:22 PDT
Thiago, it needs to enabled for everything except MAC since the code used to be compiled unconditionally.
Chris Dumez
Comment 4 2012-05-08 01:25:11 PDT
Created attachment 140688 [details] Patch
Gyuyoung Kim
Comment 5 2012-05-08 01:30:08 PDT
Comment on attachment 140688 [details] Patch Looks fine on my side.
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-05-08 07:14:35 PDT
The CMake-specific part looks fine, dunno if Eric plans on adding an option to build-webkit, though.
Chris Dumez
Comment 7 2012-05-08 07:26:34 PDT
Created attachment 140715 [details] Patch No longer update the build-webkit script.
Eric Seidel (no email)
Comment 8 2012-05-08 10:50:29 PDT
Comment on attachment 140715 [details] Patch I'll add the build-webkit option when I land the generate-feature-files script, which will hopefully be this week.
Eric Seidel (no email)
Comment 9 2012-05-08 10:50:50 PDT
You're also welcoem to add a build-webkit option if you like, it should default to on for everyone.
WebKit Review Bot
Comment 10 2012-05-08 10:57:42 PDT
Comment on attachment 140715 [details] Patch Clearing flags on attachment: 140715 Committed r116436: <http://trac.webkit.org/changeset/116436>
WebKit Review Bot
Comment 11 2012-05-08 10:57:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.