Summary: | [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thiago Marcos P. Santos <tmpsantos> | ||||
Component: | WebKit EFL | Assignee: | Thiago Marcos P. Santos <tmpsantos> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 84170, 84342 | ||||||
Attachments: |
|
Description
Thiago Marcos P. Santos
2012-04-17 11:06:22 PDT
Created attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT
Comment on attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT
While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that?
Comment on attachment 137960 [details]
add DUMPRENDERTREE_TEMP support to EFL's DRT
Icky String-concat api.
(In reply to comment #2) > (From update of attachment 137960 [details]) > While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that? When running database tests, they will all create databases at ~/.webkit/. Some tests might be testing concurrency, quota, stress and all sort of things. It generates some random results and timeouts if many tests are running in parallel (and some fail due to other tests leftovers). After this patch, they will go to a private temporary folder like /tmp/DumpRenderTree-ABCDE/Databases/ which is cleaned up later. Not to mention that DRT might potentially screw up the developer environment since ~/.webkit is the default for EWK (imagine if you are working on a browser as well). :) Comment on attachment 137960 [details] add DUMPRENDERTREE_TEMP support to EFL's DRT Clearing flags on attachment: 137960 Committed r114682: <http://trac.webkit.org/changeset/114682> All reviewed patches have been landed. Closing bug. |