Bug 84169

Summary: [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
Product: WebKit Reporter: Thiago Marcos P. Santos <tmpsantos>
Component: WebKit EFLAssignee: Thiago Marcos P. Santos <tmpsantos>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84170, 84342    
Attachments:
Description Flags
add DUMPRENDERTREE_TEMP support to EFL's DRT none

Thiago Marcos P. Santos
Reported 2012-04-17 11:06:22 PDT
DRT is creating all the databases inside ~/.webkit. This is causing unreliable/flaky tests results (specially when running tests in parallel).
Attachments
add DUMPRENDERTREE_TEMP support to EFL's DRT (1.54 KB, patch)
2012-04-19 13:17 PDT, Thiago Marcos P. Santos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thiago Marcos P. Santos
Comment 1 2012-04-19 13:17:48 PDT
Created attachment 137960 [details] add DUMPRENDERTREE_TEMP support to EFL's DRT
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-04-19 14:02:02 PDT
Comment on attachment 137960 [details] add DUMPRENDERTREE_TEMP support to EFL's DRT While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that?
Eric Seidel (no email)
Comment 3 2012-04-19 14:13:31 PDT
Comment on attachment 137960 [details] add DUMPRENDERTREE_TEMP support to EFL's DRT Icky String-concat api.
Thiago Marcos P. Santos
Comment 4 2012-04-19 14:23:34 PDT
(In reply to comment #2) > (From update of attachment 137960 [details]) > While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that? When running database tests, they will all create databases at ~/.webkit/. Some tests might be testing concurrency, quota, stress and all sort of things. It generates some random results and timeouts if many tests are running in parallel (and some fail due to other tests leftovers). After this patch, they will go to a private temporary folder like /tmp/DumpRenderTree-ABCDE/Databases/ which is cleaned up later. Not to mention that DRT might potentially screw up the developer environment since ~/.webkit is the default for EWK (imagine if you are working on a browser as well). :)
WebKit Review Bot
Comment 5 2012-04-19 15:12:57 PDT
Comment on attachment 137960 [details] add DUMPRENDERTREE_TEMP support to EFL's DRT Clearing flags on attachment: 137960 Committed r114682: <http://trac.webkit.org/changeset/114682>
WebKit Review Bot
Comment 6 2012-04-19 15:13:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.