Bug 83285

Summary: [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled.
Product: WebKit Reporter: Mariusz Grzegorczyk <mariusz.g>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, g.czajkowski, gustavo, kling, morrita, mrobinson, pnormand, rakuco, rniwa, ryuan.choi, svillar, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
none
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
rniwa: review+
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro none

Mariusz Grzegorczyk
Reported 2012-04-05 09:34:18 PDT
After applying all patches related with master bug "[EFL][WK2] Support for EFL port of WebKit2": https://bugs.webkit.org/show_bug.cgi?id=61838 build break occurs because of disabled CONTEXT_MENUS macro.
Attachments
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.40 KB, patch)
2012-04-05 09:43 PDT, Mariusz Grzegorczyk 		no flags
DetailsFormatted DiffDiff
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.46 KB, patch)
2012-04-06 00:41 PDT, Mariusz Grzegorczyk 		rniwa: review+
DetailsFormatted DiffDiff
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro (32.43 KB, patch)
2012-04-17 03:20 PDT, Mariusz Grzegorczyk 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mariusz Grzegorczyk
Comment 1 2012-04-05 09:43:31 PDT
Created attachment 135841 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
WebKit Review Bot
Comment 2 2012-04-05 23:36:29 PDT
Attachment 135841 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:26: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mariusz Grzegorczyk
Comment 3 2012-04-06 00:41:33 PDT
Created attachment 135990 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
Grzegorz Czajkowski
Comment 4 2012-04-11 00:17:38 PDT
LGTM. Some time ago patch https://bugs.webkit.org/show_bug.cgi?id=82342 has landed to repo that fixed build break when CONTEXT_MENUS is disabled in WebKit1. That patch generally improved WebCore and GTK, EFL ports of WebKit1. We need to apply this patch for WK2 to compile EFL port because context menu is not supported for EFL port yet and has to be disabled.
Ryuan Choi
Comment 5 2012-04-17 02:44:48 PDT
Could you rebase this? I can't apply this because of hunk failed on ewk_view.cpp
Mariusz Grzegorczyk
Comment 6 2012-04-17 03:20:17 PDT
Created attachment 137506 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro Rebased version.
Ryuan Choi
Comment 7 2012-04-17 04:35:21 PDT
Comment on attachment 137506 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro thanks
WebKit Review Bot
Comment 8 2012-04-17 04:56:37 PDT
Comment on attachment 137506 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro Clearing flags on attachment: 137506 Committed r114367: <http://trac.webkit.org/changeset/114367>
WebKit Review Bot
Comment 9 2012-04-17 04:56:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.