| Summary: | [EFL][WK2] Fix build break when CONTEXT_MENUS is disabled. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mariusz Grzegorczyk <mariusz.g> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | eric, g.czajkowski, gustavo, kling, morrita, mrobinson, pnormand, rakuco, rniwa, ryuan.choi, svillar, tonikitoo, webkit.review.bot |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 61838 | ||
| Attachments: | |||
|
Description
Mariusz Grzegorczyk
2012-04-05 09:34:18 PDT
Created attachment 135841 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
Attachment 135841 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:26: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 135990 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
LGTM. Some time ago patch https://bugs.webkit.org/show_bug.cgi?id=82342 has landed to repo that fixed build break when CONTEXT_MENUS is disabled in WebKit1. That patch generally improved WebCore and GTK, EFL ports of WebKit1. We need to apply this patch for WK2 to compile EFL port because context menu is not supported for EFL port yet and has to be disabled. Could you rebase this? I can't apply this because of hunk failed on ewk_view.cpp Created attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
Rebased version.
Comment on attachment 137506 [details]
Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro
thanks
Comment on attachment 137506 [details] Patch fixing webkit2 efl build caused by disabled CONTEXT_MENUS macro Clearing flags on attachment: 137506 Committed r114367: <http://trac.webkit.org/changeset/114367> All reviewed patches have been landed. Closing bug. |