Bug 82326

Summary: Enable animVal support for SVGAnimatedPreserveAspectRatio
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, kadam, ossy, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 12437, 82469    
Bug Blocks: 41761, 79666    
Attachments:
Description Flags
Patch
zherczeg: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02 none

Description Nikolas Zimmermann 2012-03-27 05:03:38 PDT
Enable animVal support for SVGAnimatedPreserveAspectRatio
Comment 1 Nikolas Zimmermann 2012-03-27 05:11:10 PDT
Created attachment 134032 [details]
Patch
Comment 2 Zoltan Herczeg 2012-03-27 05:52:34 PDT
Comment on attachment 134032 [details]
Patch

r=me

View in context: https://bugs.webkit.org/attachment.cgi?id=134032&action=review

> LayoutTests/svg/dom/preserve-aspect-ratio-parser.html:120
> +parsePreserveAspectRatio("",0, 0);

Missing space
Comment 3 WebKit Review Bot 2012-03-27 06:05:37 PDT
Comment on attachment 134032 [details]
Patch

Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12141533

New failing tests:
svg/custom/preserve-aspect-ratio-syntax.svg
Comment 4 WebKit Review Bot 2012-03-27 06:05:44 PDT
Created attachment 134040 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Nikolas Zimmermann 2012-03-28 06:14:51 PDT
Committed r112391: <http://trac.webkit.org/changeset/112391>
Comment 6 Csaba Osztrogonác 2012-03-28 07:15:52 PDT
(In reply to comment #3)
> (From update of attachment 134032 [details])
> Attachment 134032 [details] did not pass chromium-ews (chromium-xvfb):
> Output: http://queues.webkit.org/results/12141533
> 
> New failing tests:
> svg/custom/preserve-aspect-ratio-syntax.svg

It fails on GTK and Qt too. Could you check if the new results are correct or not?
Comment 7 Nikolas Zimmermann 2012-03-28 07:27:11 PDT
Ouch it was listed as skipped in platform/mac-lion/Skipped, I couldn't notice this breakage - I reran all tests and they looked fine :(

I'll investigate, you can skip it for now.
Comment 8 Ádám Kallai 2012-03-29 02:15:33 PDT
Thanks for your comment. I skipped this test on Qt.
Landed in: http://trac.webkit.org/changeset/112509
Comment 9 Csaba Osztrogonác 2012-03-29 02:35:14 PDT
Reopen, because there is a failing test.
Comment 10 Nikolas Zimmermann 2012-03-31 08:16:08 PDT
Patch at bug 82469 restores the old behavior and fixes the regression, once this lands I'll close this bug.