Bug 81353 – Moves remaining filesystem files to Modules/filesystem/

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

Moves remaining filesystem files to Modules/filesystem/

[Mark Pilgrim (Google)]

Created attachment 132286 [details]
Patch

[Mark Pilgrim (Google)]

*** Bug 81111 has been marked as a duplicate of this bug. ***

[Mark Pilgrim (Google)]

*** Bug 81149 has been marked as a duplicate of this bug. ***

[WebKit Review Bot]

Attachment 132286 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/FileSystemCallbacks.h:68:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.cpp:71:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/Modules/filesystem/EntryArray.h:51:  The parameter name "entry" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriter.h:45:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.h:71:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileWriter.cpp:173:  One line control clauses should not use braces.  [whitespace/braces] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:38:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:69:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:70:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileEntry.h:57:  The parameter name "fileSystem" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:54:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:55:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:56:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:57:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:58:  The parameter name "errorCallback" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h:42:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 16 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Barth]

Comment on attachment 132286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=132286&action=review

Looks great.  Thanks.

> Source/WebCore/Modules/filesystem/DOMFilePath.h:41
> +class DOMFilePath {

Should this class have an ENABLE(FILE_SYSTEM) ifdef?

[Mark Pilgrim (Google)]

Probably. I'll add it in a separate patch once this goes through.

[WebKit Review Bot]

Comment on attachment 132286 [details]
Patch

Rejecting attachment 132286 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
urce/WebKit/chromium/third_party/skia/third_party/glu --revision 3381 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
41>At revision 3381.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11964390

[WebKit Review Bot]

Comment on attachment 132286 [details]
Patch

Clearing flags on attachment: 132286

Committed r111075: <http://trac.webkit.org/changeset/111075>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Yael]

Qt build fix was committed in http://trac.webkit.org/changeset/111106