Summary: | Moves remaining filesystem files to Modules/filesystem/ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||
Component: | New Bugs | Assignee: | Mark Pilgrim (Google) <pilgrim> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ericu, fishd, haraken, levin+threading, ojan, rakuco, vestbo, webkit.review.bot, yael | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 81393 | ||||||
Attachments: |
|
Description
Mark Pilgrim (Google)
2012-03-16 08:10:50 PDT
Created attachment 132286 [details]
Patch
*** Bug 81111 has been marked as a duplicate of this bug. *** *** Bug 81149 has been marked as a duplicate of this bug. *** Attachment 132286 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebCore/Modules/filesystem/FileSystemCallbacks.h:68: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.cpp:71: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebCore/Modules/filesystem/EntryArray.h:51: The parameter name "entry" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriter.h:45: Missing space inside { }. [whitespace/braces] [5]
Source/WebCore/Modules/filesystem/DOMFilePath.h:71: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileWriter.cpp:173: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:38: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:69: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/DOMFileSystemBase.h:70: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5]
Source/WebCore/Modules/filesystem/FileEntry.h:57: The parameter name "fileSystem" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:54: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:55: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:56: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:57: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/Entry.h:58: The parameter name "errorCallback" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/Modules/filesystem/AsyncFileWriterClient.h:42: Missing space inside { }. [whitespace/braces] [5]
Total errors found: 16 in 74 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 132286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=132286&action=review Looks great. Thanks. > Source/WebCore/Modules/filesystem/DOMFilePath.h:41 > +class DOMFilePath { Should this class have an ENABLE(FILE_SYSTEM) ifdef? Probably. I'll add it in a separate patch once this goes through. Comment on attachment 132286 [details] Patch Rejecting attachment 132286 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: urce/WebKit/chromium/third_party/skia/third_party/glu --revision 3381 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 41>At revision 3381. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/11964390 Comment on attachment 132286 [details] Patch Clearing flags on attachment: 132286 Committed r111075: <http://trac.webkit.org/changeset/111075> All reviewed patches have been landed. Closing bug. Qt build fix was committed in http://trac.webkit.org/changeset/111106 |