Bug 79900

Summary:

[EFL][DRT] Inject internals object

Product:

WebKit

Reporter:

Kangil Han <kangil.han>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

d-r, gyuyoung.kim, gyuyoung.kim, jye.kang, kenneth, kihong.kwon, lucas.de.marchi, mxie, rakuco, rwlbuis, s.choi, tmpsantos, vimff0, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Bug Depends on:

79896

Bug Blocks:

62698, 81027

Attachments:

Description	Flags
Patch	none
Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists.	paroga: review-
New patch taking into account changes made by 79896.	gyuyoung.kim: commit-queue-
New patch fixing issues pointed by comments	none

Kangil Han

Reported 2012-02-29 02:46:24 PST

Inject internals object for EFL DRT.

Attachments
Patch (2.64 KB, patch) 2012-02-29 03:20 PST, Kangil Han	no flags	Details Formatted Diff Diff
Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. (7.71 KB, patch) 2012-02-29 08:44 PST, Thiago Marcos P. Santos	paroga: review-	Details Formatted Diff Diff
New patch taking into account changes made by 79896. (5.18 KB, patch) 2012-03-12 17:13 PDT, Thiago Marcos P. Santos	gyuyoung.kim: commit-queue-	Details Formatted Diff Diff
New patch fixing issues pointed by comments (5.27 KB, patch) 2012-03-13 04:02 PDT, Thiago Marcos P. Santos	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Kangil Han

Comment 1 2012-02-29 03:20:22 PST

Created attachment 129432 [details] Patch

Thiago Marcos P. Santos

Comment 2 2012-02-29 08:44:27 PST

Created attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. I know there is a patch on the review queue already. I ended up duplicating this work because the bugzilla was down today and I could not search if there was some work ongoing on this already. :(

Gyuyoung Kim

Comment 3 2012-02-29 20:53:40 PST

Comment on attachment 129432 [details] Patch Attachment 129432 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11770168

Raphael Kubo da Costa (:rakuco)

Comment 4 2012-03-01 17:58:44 PST

Comment on attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. I love patches which make the skipped list smaller :-) Looks fine.

Gyuyoung Kim

Comment 5 2012-03-01 18:12:12 PST

I also think EFL port needs this patch. LGTM.

Patrick R. Gansterer

Comment 6 2012-03-02 04:27:40 PST

Comment on attachment 129457 [details] Patch that injects "internals" on the window object and also removes tests relying on this feature from skip lists. testing stuff is not a part of WebCore. bug 79896 adds a new WebCoreTestSupport library. But adding the change to the Skipped list, to the other path at this bug makes sense

Thiago Marcos P. Santos

Comment 7 2012-03-12 17:13:15 PDT

Created attachment 131462 [details] New patch taking into account changes made by 79896.

Antonio Gomes

Comment 8 2012-03-12 17:36:53 PDT

will have few more for you to unskip when https://bugs.webkit.org/show_bug.cgi?id=80886 lands :-)

Kangil Han

Comment 9 2012-03-12 19:40:11 PDT

In LayoutTests/platform/efl/Skipped -># EFL's LayoutTestController does not implement shadowRoot IMHO, above description will be not valid if this patch lands. Can you modify it? (In reply to comment #7) > Created an attachment (id=131462) [details] > New patch taking into account changes made by 79896.

Kangil Han

Comment 10 2012-03-12 19:40:42 PDT

This is great! :) Thanks! (In reply to comment #8) > will have few more for you to unskip when https://bugs.webkit.org/show_bug.cgi?id=80886 lands :-)

Gyuyoung Kim

Comment 11 2012-03-12 20:31:12 PDT

Comment on attachment 131462 [details] New patch taking into account changes made by 79896. Attachment 131462 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11943318

Thiago Marcos P. Santos

Comment 12 2012-03-13 04:02:16 PDT

Created attachment 131589 [details] New patch fixing issues pointed by comments

Kangil Han

Comment 13 2012-03-13 04:07:43 PDT

LGTM Thanks! (In reply to comment #12) > Created an attachment (id=131589) [details] > New patch fixing issues pointed by comments

Thiago Marcos P. Santos

Comment 14 2012-03-13 04:15:19 PDT

(In reply to comment #9) > In LayoutTests/platform/efl/Skipped > -># EFL's LayoutTestController does not implement shadowRoot > > IMHO, above description will be not valid if this patch lands. > Can you modify it? > Done, thanks for pointing out. BTW there are 2 tests that I had to kept on the skip list that are failing only for EFL, but I don't really now the reason. I'm working on those right now and I'll open a bug as soon as I find what is happening. fast/forms/color/input-color-onchange-event.html fast/html/details-clone.html > (In reply to comment #7) > > Created an attachment (id=131462) [details] [details] > > New patch taking into account changes made by 79896.

Kangil Han

Comment 15 2012-03-13 04:23:58 PDT

I will look forward to your upcoming patch(es). :) (In reply to comment #14) > (In reply to comment #9) > > In LayoutTests/platform/efl/Skipped > > -># EFL's LayoutTestController does not implement shadowRoot > > > > IMHO, above description will be not valid if this patch lands. > > Can you modify it? > > > > Done, thanks for pointing out. BTW there are 2 tests that I had to kept on the skip list that are failing only for EFL, but I don't really now the reason. I'm working on those right now and I'll open a bug as soon as I find what is happening. > > fast/forms/color/input-color-onchange-event.html > fast/html/details-clone.html > > > > (In reply to comment #7) > > > Created an attachment (id=131462) [details] [details] [details] > > > New patch taking into account changes made by 79896.

Antonio Gomes

Comment 16 2012-03-13 07:34:13 PDT

(In reply to comment #12) > Created an attachment (id=131589) [details] > New patch fixing issues pointed by comments do you want review? :-)

Thiago Marcos P. Santos

Comment 17 2012-03-13 09:01:51 PDT

(In reply to comment #16) > (In reply to comment #12) > > Created an attachment (id=131589) [details] [details] > > New patch fixing issues pointed by comments > > do you want review? :-) Please. I was waiting for the EWS before poking you. :)

WebKit Review Bot

Comment 18 2012-03-13 14:59:39 PDT

Comment on attachment 131589 [details] New patch fixing issues pointed by comments Clearing flags on attachment: 131589 Committed r110619: <http://trac.webkit.org/changeset/110619>

Dominik Röttsches (drott)

Comment 19 2012-03-14 01:38:20 PDT

Patch was landed, closing.

Eric Seidel (no email)

Comment 20 2012-03-20 00:52:29 PDT

Comment on attachment 129432 [details] Patch Cleared review? from attachment 129432 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).

Note You need to log in before you can comment on or make changes to this bug.