| Summary: | webkitpy should support Android | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, jnd | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 78528, 78543, 78545, 78550, 78558, 78579, 78580, 78582, 78627, 79628 | ||||||
| Bug Blocks: | 66687 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2012-02-13 13:41:20 PST
Created attachment 126822 [details]
snapshot
Comment on attachment 126822 [details] snapshot View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review I would have probably broken this file out into smaller pieces, but I think that's also something we can do later after the android port is working. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:493 > +class ChromiumAndroidDriver(chromium.ChromiumDriver): > + """Abstract interface for test_shell.""" Really? We have yet another driver...? > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:78 > + _set_gpu_options(self) Odd function. > Tools/Scripts/webkitpy/layout_tests/port/factory.py:76 > + else: > + return 'chromium-linux' No else after return. Comment on attachment 126822 [details] snapshot View in context: https://bugs.webkit.org/attachment.cgi?id=126822&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:50 > +_log = logging.getLogger('webkitpy.layout_tests.port.chromium_android') I think we normally use getLogger(__file__) This is done. I don't have a target device, so it's hard for me to test that everything is working. I suspect there are some bugs, but we can handle them separately as we find them. |