Bug 78260

Summary:

win test_expectations and Skipped have duplicates

Product:

WebKit

Reporter:

Stephen Chenney <schenney>

Component:

Tools / Tests

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, jchaffraix, robert

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Description Stephen Chenney 2012-02-09 11:34:26 PST

The following errors are generated from the style checker if you modify platform/win/test_expectations.txt:

----------------

LayoutTests/platform/win/test_expectations.txt:28:  tables/mozilla/bugs/bug1163-1.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:29:  tables/mozilla/bugs/bug119786.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:30:  tables/mozilla/bugs/bug1302.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:31:  tables/mozilla/bugs/bug222846.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:32:  tables/mozilla/bugs/bug29058-3.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:33:  tables/mozilla/bugs/bug48028-1.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:34:  tables/mozilla/bugs/bug48028-2.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:35:  tables/mozilla/bugs/bug5838.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:36:  tables/mozilla/bugs/bug6304.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:37:  tables/mozilla/bugs/bug8381.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:38:  tables/mozilla/core/captions.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:39:  tables/mozilla/marvin/backgr_layers-opacity.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:40:  tables/mozilla/marvin/backgr_position-table.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:41:  tables/mozilla/marvin/backgr_simple-table-cell.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:42:  tables/mozilla/marvin/backgr_simple-table-column-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:43:  tables/mozilla/marvin/backgr_simple-table-column.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:44:  tables/mozilla/marvin/backgr_simple-table-row-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:45:  tables/mozilla/marvin/backgr_simple-table-row.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:46:  tables/mozilla/marvin/backgr_simple-table.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:47:  tables/mozilla/marvin/table_frame_border.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:48:  tables/mozilla/marvin/table_frame_box.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:49:  tables/mozilla/marvin/table_rules_all.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:50:  tables/mozilla/marvin/table_rules_none.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:51:  tables/mozilla/marvin/tables_caption_align_bot.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:52:  tables/mozilla/marvin/tables_caption_align_top.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:53:  tables/mozilla/marvin/x_caption_align_bottom.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:54:  tables/mozilla/marvin/x_caption_align_top.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:55:  tables/mozilla/marvin/x_caption_class.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:56:  tables/mozilla/marvin/x_caption_id.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:57:  tables/mozilla/marvin/x_caption_style.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:58:  tables/mozilla_expected_failures/bugs/bug10140.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:59:  tables/mozilla_expected_failures/bugs/bug10216.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:60:  tables/mozilla_expected_failures/bugs/bug104898.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:61:  tables/mozilla_expected_failures/bugs/bug106966.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:62:  tables/mozilla_expected_failures/bugs/bug14007-2.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:63:  tables/mozilla_expected_failures/bugs/bug29058-2.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:64:  tables/mozilla_expected_failures/bugs/bug3166-11.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:65:  tables/mozilla_expected_failures/bugs/bug3166-12.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:66:  tables/mozilla_expected_failures/bugs/bug3166-13.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:67:  tables/mozilla_expected_failures/bugs/bug3166-14.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:68:  tables/mozilla_expected_failures/bugs/bug3166-16.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:69:  tables/mozilla_expected_failures/bugs/bug3166-17.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:70:  tables/mozilla_expected_failures/bugs/bug3166-3.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:71:  tables/mozilla_expected_failures/bugs/bug3166-4.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:72:  tables/mozilla_expected_failures/bugs/bug3166-5.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:73:  tables/mozilla_expected_failures/bugs/bug3166-6.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:74:  tables/mozilla_expected_failures/bugs/bug3166-9.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:75:  tables/mozilla_expected_failures/bugs/bug91057.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:76:  tables/mozilla_expected_failures/core/captions1.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:77:  tables/mozilla_expected_failures/core/captions2.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:78:  tables/mozilla_expected_failures/core/captions3.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:79:  tables/mozilla_expected_failures/marvin/backgr_border-table-cell.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:80:  tables/mozilla_expected_failures/marvin/backgr_border-table-column-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:81:  tables/mozilla_expected_failures/marvin/backgr_border-table-column.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:82:  tables/mozilla_expected_failures/marvin/backgr_border-table-quirks.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:83:  tables/mozilla_expected_failures/marvin/backgr_border-table-row-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:84:  tables/mozilla_expected_failures/marvin/backgr_border-table-row.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:85:  tables/mozilla_expected_failures/marvin/backgr_border-table.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:86:  tables/mozilla_expected_failures/marvin/backgr_fixed-bg.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:87:  tables/mozilla_expected_failures/marvin/backgr_layers-hide.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:88:  tables/mozilla_expected_failures/marvin/backgr_position-table-cell.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:89:  tables/mozilla_expected_failures/marvin/backgr_position-table-column-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:90:  tables/mozilla_expected_failures/marvin/backgr_position-table-column.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:91:  tables/mozilla_expected_failures/marvin/backgr_position-table-row-group.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:92:  tables/mozilla_expected_failures/marvin/backgr_position-table-row.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:93:  tables/mozilla_expected_failures/marvin/table_frame_vsides.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:94:  tables/mozilla_expected_failures/marvin/table_overflow_caption.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:95:  tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:96:  tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:97:  tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:98:  tables/mozilla_expected_failures/marvin/table_overflow_caption_left.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:99:  tables/mozilla_expected_failures/marvin/table_overflow_caption_right.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:100:  tables/mozilla_expected_failures/marvin/table_overflow_caption_top.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:101:  tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:102:  tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:103:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:104:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:105:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:106:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:107:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:108:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:109:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:110:  tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:111:  tables/mozilla_expected_failures/marvin/table_rules_cols.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:112:  tables/mozilla_expected_failures/marvin/table_rules_rows.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:113:  tables/mozilla_expected_failures/marvin/tables_caption_align_left.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:114:  tables/mozilla_expected_failures/marvin/tables_caption_align_right.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:115:  tables/mozilla_expected_failures/marvin/x_caption_align_left.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:116:  tables/mozilla_expected_failures/marvin/x_caption_align_right.xml is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:117:  tables/mozilla_expected_failures/other/test4.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:118:  tables/mozilla/bugs/bug29157.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:119:  tables/mozilla/other/wa_table_thtd_rowspan.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:120:  tables/mozilla/other/wa_table_tr_align.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:121:  tables/mozilla_expected_failures/marvin/backgr_layers-show.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:122:  tables/mozilla_expected_failures/marvin/table_frame_lhs.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:123:  tables/mozilla_expected_failures/marvin/table_frame_rhs.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:124:  fast/css/bidi-override-in-anonymous-block.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:125:  fast/dom/HTMLTableElement/colSpan.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:126:  fast/dom/HTMLTableElement/createCaption.html is also in a Skipped file.  [test/expectations] [5]
LayoutTests/platform/win/test_expectations.txt:127:  fast/repaint/table-section-repaint.html is also in a Skipped file.  [test/expectations] [5]

---------------

These files also appear at the end of the Skipped file for win. There may not be an exact correspondence, because I think a slightly different set of lines is involved: 28-127 in test_expectations, 1532-1631

Comment 1 Julien Chaffraix 2012-02-09 11:57:33 PST

FYI this is related to those 2 changesets:

http://trac.webkit.org/changeset/103875 (table change, added the files to test_expectations.txt)
http://trac.webkit.org/changeset/103876 (fixup, added the files to Skipped)

From the comment in the second revision, it looks like it should just be removed from test_expectations.txt. Thoughts?

Comment 2 Julien Chaffraix 2012-02-09 18:59:53 PST

Created attachment 126430 [details]
Patch

Comment 3 Julien Chaffraix 2012-02-10 09:19:31 PST

Committed r107405: <http://trac.webkit.org/changeset/107405>

Comment 4 Robert Hogan 2012-02-10 11:22:38 PST

Julien: I owe you one!