Bug 222846 - git-webkit should have an "info" command
Summary: git-webkit should have an "info" command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-03-05 18:52 PST by Ryosuke Niwa
Modified: 2021-03-10 09:02 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.89 KB, patch)
2021-03-09 12:13 PST, Jonathan Bedard
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2021-03-05 18:52:22 PST
We need "git-webkit info" that behaves like "svn info" and show the last commit identifier.
Comment 1 Radar WebKit Bug Importer 2021-03-08 08:27:02 PST
<rdar://problem/75171053>
Comment 2 Jonathan Bedard 2021-03-08 08:30:11 PST
Does `Tools/Scripts/git-webkit find HEAD` get you the information you want? My inclination is to make an "info" command that is essentially an alias to that.
Comment 3 Ryosuke Niwa 2021-03-08 19:08:14 PST
(In reply to Jonathan Bedard from comment #2)
> Does `Tools/Scripts/git-webkit find HEAD` get you the information you want?
> My inclination is to make an "info" command that is essentially an alias to
> that.

Sure, that works for me but can we reorder so that the identifier appears at the end? It's sort of buried between author name, date, etc... right now. I want it to stand out and showing at the end will do.
Comment 4 Jonathan Bedard 2021-03-09 12:13:06 PST
Created attachment 422740 [details]
Patch
Comment 5 Jonathan Bedard 2021-03-09 12:14:22 PST
I will do the re-order in a separate change, the original order was somewhat arbitrary anyways.
Comment 6 Ryosuke Niwa 2021-03-09 22:46:51 PST
Comment on attachment 422740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422740&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34
> +class Info(Command):
> +    name = 'info'
> +    help = 'Print information about the HEAD commit'

This seems a bit backwards? Why not define info in terms of find instead?
Comment 7 Jonathan Bedard 2021-03-10 07:45:06 PST
(In reply to Ryosuke Niwa from comment #6)
> Comment on attachment 422740 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422740&action=review
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34
> > +class Info(Command):
> > +    name = 'info'
> > +    help = 'Print information about the HEAD commit'
> 
> This seems a bit backwards? Why not define info in terms of find instead?

Was my thought originally too, but you don't have a great way to strip the ref argument when constructing the argparser, it makes more sense to add it.
Comment 8 EWS 2021-03-10 07:49:06 PST
Committed r274214: <https://commits.webkit.org/r274214>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422740 [details].