Bug 222846 – git-webkit should have an "info" command

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

We need "git-webkit info" that behaves like "svn info" and show the last commit identifier.

[Radar WebKit Bug Importer]

<rdar://problem/75171053>

[Jonathan Bedard]

Does `Tools/Scripts/git-webkit find HEAD` get you the information you want? My inclination is to make an "info" command that is essentially an alias to that.

[Ryosuke Niwa]

(In reply to Jonathan Bedard from comment #2)
> Does `Tools/Scripts/git-webkit find HEAD` get you the information you want?
> My inclination is to make an "info" command that is essentially an alias to
> that.

Sure, that works for me but can we reorder so that the identifier appears at the end? It's sort of buried between author name, date, etc... right now. I want it to stand out and showing at the end will do.

[Jonathan Bedard]

Created attachment 422740 [details]
Patch

[Jonathan Bedard]

I will do the re-order in a separate change, the original order was somewhat arbitrary anyways.

[Ryosuke Niwa]

Comment on attachment 422740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422740&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34
> +class Info(Command):
> +    name = 'info'
> +    help = 'Print information about the HEAD commit'

This seems a bit backwards? Why not define info in terms of find instead?

[Jonathan Bedard]

(In reply to Ryosuke Niwa from comment #6)
> Comment on attachment 422740 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=422740&action=review
> 
> > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:34
> > +class Info(Command):
> > +    name = 'info'
> > +    help = 'Print information about the HEAD commit'
> 
> This seems a bit backwards? Why not define info in terms of find instead?

Was my thought originally too, but you don't have a great way to strip the ref argument when constructing the argparser, it makes more sense to add it.

[EWS]

Committed r274214: <https://commits.webkit.org/r274214>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422740 [details].