Bug 29058 - Make SVGStyleElement inherit from SVGLangSpace
Summary: Make SVGStyleElement inherit from SVGLangSpace
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
Depends on: 29059
  Show dependency treegraph
Reported: 2009-09-08 16:11 PDT by Cameron McCormack (:heycam)
Modified: 2009-09-09 17:55 PDT (History)
3 users (show)

See Also:

Patch v1 (8.84 KB, patch)
2009-09-08 16:31 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2009-09-08 16:11:25 PDT
SVG 1.1 Second Edition drops the xmlspace attribute from SVGStyleElement and makes it inherit from SVGLangSpace to gain xmlspace and xmllang:

Comment 1 Cameron McCormack (:heycam) 2009-09-08 16:31:00 PDT
Created attachment 39227 [details]
Patch v1

Note that the test doesn't actually check that the xmllang and xmlspace properties reflect the attributes on the <style> element.  Bug 26371 should fix that.
Comment 2 Eric Seidel (no email) 2009-09-09 08:11:15 PDT
Comment on attachment 39227 [details]
Patch v1

Looks great!
Comment 3 Eric Seidel (no email) 2009-09-09 08:16:02 PDT
Comment on attachment 39227 [details]
Patch v1

Rejecting patch 39227 from commit-queue.

This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39227 from bug 29058 failed to download and apply.
Comment 4 Eric Seidel (no email) 2009-09-09 09:37:02 PDT
svn-apply does not seem to like your patch files:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
|Index: LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html
|--- LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html	(revision 0)
|+++ LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html	(working copy)
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Can't open 'LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html': No such file or directory at /Users/eseidel/Projects/WebKit2/WebKitTools/Scripts/svn-apply line 256, <> line 238.
Comment 5 Cameron McCormack (:heycam) 2009-09-09 15:56:38 PDT
(In reply to comment #4)
> svn-apply does not seem to like your patch files:

The fix in bug 29059 should let svn-apply work on this patch.
Comment 6 WebKit Commit Bot 2009-09-09 17:55:40 PDT
Comment on attachment 39227 [details]
Patch v1

Clearing flags on attachment: 39227

Committed r48239: <http://trac.webkit.org/changeset/48239>
Comment 7 WebKit Commit Bot 2009-09-09 17:55:44 PDT
All reviewed patches have been landed.  Closing bug.