Bug 29058 – Make SVGStyleElement inherit from SVGLangSpace

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Cameron McCormack (:heycam)]

SVG 1.1 Second Edition drops the xmlspace attribute from SVGStyleElement and makes it inherit from SVGLangSpace to gain xmlspace and xmllang:

  http://dev.w3.org/SVG/profiles/1.1F2/publish/styling.html#InterfaceSVGStyleElement

[Cameron McCormack (:heycam)]

Created attachment 39227 [details]
Patch v1

Note that the test doesn't actually check that the xmllang and xmlspace properties reflect the attributes on the <style> element.  Bug 26371 should fix that.

[Eric Seidel (no email)]

Comment on attachment 39227 [details]
Patch v1

Looks great!

[Eric Seidel (no email)]

Comment on attachment 39227 [details]
Patch v1

Rejecting patch 39227 from commit-queue.

This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=39227 from bug 29058 failed to download and apply.

[Eric Seidel (no email)]

svn-apply does not seem to like your patch files:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html
|===================================================================
|--- LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html	(revision 0)
|+++ LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
Can't open 'LayoutTests/svg/dom/SVGStyleElement/resources/TEMPLATE.html': No such file or directory at /Users/eseidel/Projects/WebKit2/WebKitTools/Scripts/svn-apply line 256, <> line 238.

[Cameron McCormack (:heycam)]

(In reply to comment #4)
> svn-apply does not seem to like your patch files:

The fix in bug 29059 should let svn-apply work on this patch.

[WebKit Commit Bot]

Comment on attachment 39227 [details]
Patch v1

Clearing flags on attachment: 39227

Committed r48239: <http://trac.webkit.org/changeset/48239>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.