Bug 48028 - Adding MediaQueryListListener binding test cases
Summary: Adding MediaQueryListListener binding test cases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Luiz Agostini
URL:
Keywords:
Depends on:
Blocks: 37205
  Show dependency treegraph
 
Reported: 2010-10-20 16:42 PDT by Luiz Agostini
Modified: 2010-10-21 04:04 PDT (History)
2 users (show)

See Also:


Attachments
patch (58.30 KB, patch)
2010-10-20 17:11 PDT, Luiz Agostini
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2010-10-20 16:42:35 PDT
MediaQueryListListener type will need special handling of the code generators. Adding the test cases.
Comment 1 Luiz Agostini 2010-10-20 17:11:00 PDT
Created attachment 71370 [details]
patch
Comment 2 Darin Adler 2010-10-20 17:40:50 PDT
Comment on attachment 71370 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71370&action=review

Assuming you generated these files with run-bindings-tests, r=me.

> WebCore/ChangeLog:18
> +        (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListenerPrivate::WebDOMTestMediaQueryListListenerPrivate):
> +        (WebDOMTestMediaQueryListListener::WebDOMTestMediaQueryListListener):
> +        (WebDOMTestMediaQueryListListener::operator=):
> +        (WebDOMTestMediaQueryListListener::impl):
> +        (WebDOMTestMediaQueryListListener::~WebDOMTestMediaQueryListListener):
> +        (WebDOMTestMediaQueryListListener::method):
> +        (toWebCore):
> +        (toWebKit):

You can leave out these lists of functions in added files.
Comment 3 WebKit Commit Bot 2010-10-21 04:04:12 PDT
Comment on attachment 71370 [details]
patch

Clearing flags on attachment: 71370

Committed r70226: <http://trac.webkit.org/changeset/70226>
Comment 4 WebKit Commit Bot 2010-10-21 04:04:17 PDT
All reviewed patches have been landed.  Closing bug.