Bug 78026

Summary: [Qt] REGRESSION(r106918): It made svg/as-object/nested-embedded-svg-size-changes.html fail in debug mode
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Critical CC: hausmann, kling, ossy, rhodovan.u-szeged, yuzo, zherczeg, zimmermann
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 77736    
Attachments:
Description Flags
Patch
none
Patch v2 kling: review+

Csaba Osztrogonác
Reported 2012-02-07 13:20:29 PST
After r106918 svg/as-object/nested-embedded-svg-size-changes.html started to fail in debug mode: --- /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/layout-test-results/svg/as-object/nested-embedded-svg-size-changes-expected.txt +++ /home/webkitbuildbot/slaves/debug64bit/buildslave/qt-linux-64-debug/build/layout-test-results/svg/as-object/nested-embedded-svg-size-changes-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: line 9: TypeError: 'undefined' is not an object (evaluating 'svgDoc.defaultView') +FAIL: Timed out waiting for notifyDone to be called This test checks that intrinsic size changes of an embedded SVG cause immediate updates of the object that embeds it. @@ -12,12 +14,3 @@ PASS document.defaultView.getComputedStyle(object1).width is "400px" PASS document.defaultView.getComputedStyle(object1).height is "200px" -Check final <object> size, after resizing finished -PASS document.defaultView.getComputedStyle(object1).width is "400px" -PASS document.defaultView.getComputedStyle(object1).height is "200px" - -Test passed if you see two green rectangles -PASS successfullyParsed is true - -TEST COMPLETE - svg/as-object/nested-embedded-svg-size-changes.html passes with singly run, but you can reproduce this fail easily with run svg/as-object tests in debug mode.
Attachments
Patch (3.66 KB, patch)
2012-02-09 03:26 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (4.56 KB, patch)
2012-02-09 03:34 PST, Nikolas Zimmermann 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-02-07 14:03:15 PST
I skipped this test to make buildbot green to be able catch new regressions - http://trac.webkit.org/changeset/106989 Please unskip it with the proper fix.
Nikolas Zimmermann
Comment 2 2012-02-09 02:45:34 PST
Chromium with v8 sees a similar problem, see bug 77183.
Nikolas Zimmermann
Comment 3 2012-02-09 03:26:45 PST
*** Bug 77183 has been marked as a duplicate of this bug. ***
Nikolas Zimmermann
Comment 4 2012-02-09 03:26:46 PST
Created attachment 126270 [details] Patch
Nikolas Zimmermann
Comment 5 2012-02-09 03:34:02 PST
Created attachment 126273 [details] Patch v2
Nikolas Zimmermann
Comment 6 2012-02-09 03:44:26 PST
I'll land this now, and see whether Qt stays green, and watch the cr flakiness dashboard, for any changes.
Nikolas Zimmermann
Comment 7 2012-02-09 03:45:26 PST
Committed r107213: <http://trac.webkit.org/changeset/107213>
Nikolas Zimmermann
Comment 8 2012-02-09 04:26:21 PST
(In reply to comment #7) > Committed r107213: <http://trac.webkit.org/changeset/107213> Oops, had a last minute typo, fixed in r107218 - now I hope it works.
Nikolas Zimmermann
Comment 9 2012-02-09 05:00:26 PST
Reopening, not convinced its fixed yet.
Nikolas Zimmermann
Comment 10 2012-02-09 06:05:47 PST
The fix from r107213 made it work on Qt Debug, according to: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Debug/builds/20988. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.