Bug 75253

Summary: [GTK] Implement zoom in/out in MiniBrowser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo.noronha, gustavo, pnormand, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 75248    
Bug Blocks:    
Attachments:
Description Flags
Patch gustavo: review+, gustavo.noronha: commit-queue-

Carlos Garcia Campos
Reported 2011-12-27 06:51:08 PST
Add zoom in and out buttons to the toolbar.
Attachments
Patch (4.67 KB, patch)
2011-12-27 06:52 PST, Carlos Garcia Campos 		gustavo: review+
gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-12-27 06:52:55 PST
Created attachment 120585 [details] Patch
Collabora GTK+ EWS bot
Comment 2 2011-12-27 07:17:33 PST
Comment on attachment 120585 [details] Patch Attachment 120585 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11038352
Gustavo Noronha (kov)
Comment 3 2012-02-16 16:01:00 PST
Comment on attachment 120585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120585&action=review Looks good. This doesn't depend on the decision in bug 75249, so I'll r+ > Tools/MiniBrowser/gtk/BrowserWindow.c:186 > + return zoomLevel <= maximumZoomLevel; I guess this should be zoomLevel < maximumZoomLevel, otherwise you would be reporting you can zoom in while being at the maximum zoom level. > Tools/MiniBrowser/gtk/BrowserWindow.c:192 > + return zoomLevel >= minimumZoomLevel; Same here.
Carlos Garcia Campos
Comment 4 2012-02-17 03:10:20 PST
Committed r108056: <http://trac.webkit.org/changeset/108056>
Note You need to log in before you can comment on or make changes to this bug.