Summary: | [GTK] Add zoom-text-only setting to WebKit2 GTK+ API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, mrobinson, pnormand, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 75248 | ||||||
Bug Blocks: | 75252 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-12-27 06:37:20 PST
Created attachment 120581 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API As I said on the mailing list I'm not sure if "text-only" is entirely accurate. I agree, Martin. How about we make the setting enable-full-content-zoom, enabled by default, instead? That way we stick to wk1's familiar existing property name and semantics, and do not use conceptually incorrect names. If you agree to that, I believe the patch is otherwise OK. (In reply to comment #4) > I agree, Martin. How about we make the setting enable-full-content-zoom, enabled by default, instead? That way we stick to wk1's familiar existing property name and semantics, and do not use conceptually incorrect names. If you agree to that, I believe the patch is otherwise OK. Sure, sounds good to me. We already agreed on the mailing list that 'text' is accurate and it's a reasonable name: https://lists.webkit.org/pipermail/webkit-gtk/2011-December/000865.html Form controls are scaled because they contain text, but text zoom factor is exactly that, so it's very accurate I would say. The text scale factor is applied to the font size. Comment on attachment 120581 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120581&action=review Let's do this. We can always go back and review this API anyway =P > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:766 > + * text of the page or all the contents. Can you add a bit about text size also affecting things like form controls? Committed r109229: <http://trac.webkit.org/changeset/109229> |