Bug 75248

Summary: [GTK] Add methods to get/set the WebView zoom level to WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, pnormand, webkit.review.bot
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 75249, 75253    
Attachments:
Description Flags
Patch gustavo: review+

Carlos Garcia Campos
Reported 2011-12-27 06:32:20 PST
Add webkit_web_view_set_zoom_level() and webkit_web_view_get_zoom_level()
Attachments
Patch (7.29 KB, patch)
2011-12-27 06:35 PST, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-12-27 06:35:15 PST
Created attachment 120579 [details] Patch It uses the page zoom factor unconditionally for now.
WebKit Review Bot
Comment 2 2011-12-27 06:38:08 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2012-01-05 05:00:32 PST
Comment on attachment 120579 [details] Patch LGTM, for those not following along at home, the way this API will look in the future may change following discussions in the webkit-gtk mailing list, but this part here I think is pretty much a consensus will exist, even if the name changes to contain 'page' somewhere.
Carlos Garcia Campos
Comment 4 2012-01-05 05:04:58 PST
Committed r104145: <http://trac.webkit.org/changeset/104145>
Note You need to log in before you can comment on or make changes to this bug.